Fix the default implementation of Differentiable for Hashable #115
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
The default implementation of Differentiabe for Hashable has a
differenceIdentifier
property. The implementation of this propeprty now returnhashValue
instead ofself
.Related Issue
The above code produces a
delete -> insert
change, however, it should be aupdate
change.#114: Unexpected behavior when using the default implementations of
Differentiable
forHashable
Motivation and Context
Close #114
Impact on Existing Code
If the existing code rely on the default implementation of Differentiable for Hashable, the reload behavior may changes. Some
delete -> insert
changes will becomeupdate
changes.