Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Create control plane endpoint for Valkyrie plugin and cleanout Auth API canned responses #457

Closed
tpboudreau-rackspace opened this issue Oct 12, 2015 · 2 comments
Assignees
Labels

Comments

@tpboudreau-rackspace
Copy link
Contributor

Changes introduced in PRs #444 and #454 (adding canned responses for the Identity API) and PRs #409 and #445 (adding a Valkyrie plugin) created an undesirable coupling between the Identity and Valkyrie API plugins.

These PRs landed with an explicit pledge by @tpboudreau-rackspace to (1) remove the included Valkyrie fixtures; (2) add a control plane mechanism to the Valkyrie API to load fixtures; and (3) remove the canned response fixtures from the Identity plugin that are tied to the Valkyrie plugin in favor of a control plane mechanism.

@tpboudreau-rackspace tpboudreau-rackspace self-assigned this Oct 12, 2015
@glyph
Copy link
Contributor

glyph commented Oct 12, 2015

@tpboudreau-rackspace Thanks for creating this :). Would you mind creating separate issues for each of these three things? Issues with an "and" in their name are always trouble if they need to land all at once.

@glyph glyph added the label Oct 12, 2015
@tpboudreau-rackspace
Copy link
Contributor Author

Sorry for the delay on this @glyph. Closed in favor of #467, #468, and #469.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants