Increase timeout for flakey GH tests #334
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KennyHuRadar
changed the title
KennyHuRadar
changed the title
lmeier
reviewed
Apr 30, 2024
| @@ -823,7 +823,7 @@ - (void)test_Radar_getContext_errorLocation { | |||
| [expectation fulfill]; | |||
| }]; | |||
|
|
|||
| [self waitForExpectationsWithTimeout:60 | |||
| [self waitForExpectationsWithTimeout:120 | |||
There was a problem hiding this comment.
What's the explanation for why we weren't seeing this before? Or were we?
There was a problem hiding this comment.
we were, they come sporadically after we upgraded the github action to simulate an iphone 15 pro
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
getContextseem to randomly timing out on github action.This is likely an issue with github action because
As a sanity check, the SDK endpoint for
getContextwas called on waypoint with no noticeable issue.