fix: assume RaBe time for archiv requests #328
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hairmare
commented
Jul 12, 2024
tests/strategy/test_past.py
Outdated
| @@ -11,14 +11,14 @@ | |||
| def test_get_show(archiv_mock): # noqa: ARG001 | |||
| """Test get_data.""" | |||
|
|
|||
| with freeze_time("1993-03-01 13:12:00 UTC"): | |||
| with freeze_time("1993-03-01 12:12:00 UTC"): | |||
There was a problem hiding this comment.
this breaks local devs envs that don't have TZ=UTC
|
this is still wrong o_O -crid://rabe.ch/v1/klangbecken#t=clock=20240117T000116.00Z
+crid://rabe.ch/v1/klangbecken#t=clock=20240116T230116.00Z(clock needs to be UTC like before) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pastCRIDs #244