Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

is there a tiny fault in the djangohtml.json #480

Open
ZG-N1 opened this issue Aug 7, 2024 · 0 comments · May be fixed by #497
Open

is there a tiny fault in the djangohtml.json #480

ZG-N1 opened this issue Aug 7, 2024 · 0 comments · May be fixed by #497
Labels
good first issue Good for newcomers

Comments

@ZG-N1
Copy link

ZG-N1 commented Aug 7, 2024

the source text looks like below:
`
"block": {

    "prefix": "block",
    "description": "block tag django template",
    "body": [
        "{% block ${blockname} %}",
        "$2",
        "{% endblock ${blockname} %}"
    ]

}maybe it should be changed to this: "block": {

    "prefix": "block",
    "description": "block tag django template",
    "body": [
        "{% block $1 %}",
        "$2",
        "{% endblock %}"
    ]

}`
@OkelleyDevelopment OkelleyDevelopment added the good first issue Good for newcomers label Sep 23, 2024
@ValdezFOmar ValdezFOmar linked a pull request Sep 24, 2024 that will close this issue
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(djangohtml): fix name placeholder in block tag ValdezFOmar/friendly-snippets
2 participants
@ZG-N1 @OkelleyDevelopment