Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update balance proof in the messaging protocol #15

Closed
loredanacirstea opened this issue Feb 28, 2018 · 2 comments · Fixed by #18
Closed

Update balance proof in the messaging protocol #15

loredanacirstea opened this issue Feb 28, 2018 · 2 comments · Fixed by #18

Comments

@loredanacirstea
Copy link
Contributor

loredanacirstea commented Feb 28, 2018

unique_channel_id is now defined as Channel specific data for reply attack prevention

Field Name Field Type Description
channel_identifier uint Channel identifier inside the TokenNetwork contract
token_network_address address Address of the TokenNetwork contract
chain_id uint Chain identifier as defined in EIP155
@hackaugusto
Copy link
Contributor

This version is missing data for replay attack protection, one way of defining the channel id is to use a tuple:
unique_channel_id = (chain_id, token_network_adress, channel_id)
IOW, we need to add a field for the chain_id (or one block hash, but that is way harder to implement)

@loredanacirstea
Copy link
Contributor Author

Updated description. So, instead of unique_channel_id - have 3 separate values. The smart contract needs the channel_identifier as a readable parameter (in case you guys thought of having a hash of the 3 values as the unique_channel_id).

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants