From afe13987793a7ca6bc94e7ea2c8e9efb0cb2fb1b Mon Sep 17 00:00:00 2001 From: tmesquita Date: Wed, 21 Dec 2016 11:11:00 -0700 Subject: [PATCH] fixing error raised when converting an empty array/relation into csv --- lib/rails_admin/support/csv_converter.rb | 3 +++ spec/rails_admin/support/csv_converter_spec.rb | 9 +++++++++ 2 files changed, 12 insertions(+) diff --git a/lib/rails_admin/support/csv_converter.rb b/lib/rails_admin/support/csv_converter.rb index 0a71f47e8e..a072e0088f 100644 --- a/lib/rails_admin/support/csv_converter.rb +++ b/lib/rails_admin/support/csv_converter.rb @@ -4,6 +4,9 @@ module RailsAdmin class CSVConverter def initialize(objects = [], schema = {}) + @fields = [] + @associations = [] + return self if (@objects = objects).blank? @model = objects.dup.first.class diff --git a/spec/rails_admin/support/csv_converter_spec.rb b/spec/rails_admin/support/csv_converter_spec.rb index 8cc6ff08be..3783859701 100644 --- a/spec/rails_admin/support/csv_converter_spec.rb +++ b/spec/rails_admin/support/csv_converter_spec.rb @@ -112,5 +112,14 @@ end end end + + context "when objects is empty" do + let(:objects) { [] } + let(:options) { {} } + + it "generates an empty csv" do + expect(subject[2]).to eq("\n") + end + end end end