Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Code isuue #1

Open
Emimal opened this issue Jul 17, 2019 · 1 comment
Open

Code isuue #1

Emimal opened this issue Jul 17, 2019 · 1 comment

Comments

@Emimal
Copy link

Emimal commented Jul 17, 2019

if scale >= 2:
output = Subpixel(64, (3,3), r = 2,padding='same',activation='relu')(output)
if scale >= 4:
output = Subpixel(64, (3,3), r = 2,padding='same',activation='relu')(output)
if scale >= 8:
output = Subpixel(64, (3,3), r = 2,padding='same',activation='relu')(output)

All the three lines are same.

Isn't it

output = Subpixel(64, (3, 3), r=scale, padding='same', activation='relu')(output) ?

@rajatkb
Copy link
Owner

rajatkb commented Jul 29, 2019

I think when working on the paper, the paper was not explicitly mentioning what do to when we need to output in scales above 4 or 8. I figured that using the pixel shuffle upscaling a number of times for higher upscales won't hurt. I verified it by changing r = 8 , or using the same operation 3 times. The final results are based on this final variant of code. The code only applies the same operation 3 times if scale is set to 8 , 2 times if 4 and 1 time is 2. I am looking into the paper again , to look at how to do higher level upscaling (progressively or imediately upscale to the scale)

PS: I just checked my mail exchange with the author he they also did the same, you can either put r = scale or scale it up multi stage, they are saying it has same effect. However i remember i verified by repeated experiment which one works. Since I used the same configuration to add perceptual loss to it.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants