Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Modify catalogue item edit dialogue error messages when has children #1136

Open
joelvdavies opened this issue Nov 21, 2024 · 0 comments · May be fixed by #1165
Open

Modify catalogue item edit dialogue error messages when has children #1136

joelvdavies opened this issue Nov 21, 2024 · 0 comments · May be fixed by #1165
Assignees
@rowan04
Labels
enhancement Improved or refactored feature

Comments

@joelvdavies
Copy link
Collaborator

Following on from ral-facilities/inventory-management-system-api#418. We now get error messages like
image
This should be modified on the front end so its more user friendly e.g. manufacturer_id should be replaced by manufacturer.
@joelvdavies joelvdavies added the enhancement Improved or refactored feature label Nov 21, 2024
@joshuadkitenge joshuadkitenge mentioned this issue Nov 21, 2024
Closed
@joelvdavies joelvdavies mentioned this issue Nov 21, 2024
Merged
4 tasks
rowan04 added a commit that referenced this issue Dec 17, 2024
@rowan04
Add cypress tests for dialogue error message if catalogue item has ch…
b1a204e 
…ildren #1136
rowan04 added a commit that referenced this issue Dec 17, 2024
@rowan04
Add/modify unit tests for catalogue item error message when has child…
5e904df 
…ren edit #1136
@rowan04 rowan04 linked a pull request Dec 17, 2024 that will close this issue
Open
4 tasks
rowan04 added a commit that referenced this issue Dec 18, 2024
@rowan04
Fix failing tests and add comments #1136
80c4670 
- fixes failing linting test
- fixes mistakes in cypress test
- adds manufacturerList to dependency array
- adds helpful comments
@rowan04 rowan04 moved this from Backlog to In Review in Inventory Management System Dec 18, 2024
rowan04 added a commit that referenced this issue Jan 7, 2025
@rowan04
move string transformation from backend response to frontend #1136
4172329
rowan04 added a commit that referenced this issue Jan 7, 2025
@rowan04
add manufacturer name into error messages in tests #1136
380b481
rowan04 added a commit that referenced this issue Jan 8, 2025
@rowan04
Add missing semi-colons #1136
fd5822e
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@rowan04 rowan04

Labels
enhancement Improved or refactored feature
Projects
Inventory Management System
Status: In Review
Milestone
No milestone
2 participants
@joelvdavies @rowan04