Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Auth code flow, redirect server. #417

Open
blueforesticarus opened this issue May 26, 2023 · 4 comments
Open

Auth code flow, redirect server. #417

blueforesticarus opened this issue May 26, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@blueforesticarus
Copy link

Is your feature request related to a problem? Please describe.
In the auth code flow, it is inconvenient have to paste the redirect url in the terminal. This is obviously an issue if the program might not be run in a interactive shell.

Describe the solution you'd like
A convenience method like prompt_for_token but which spins up a local server listening to the redirect url, using it to get the code semi-automatically. Ideally should take allow multible redirect_urls (which spotify supports) as fallback (in case port is in use, for example). prompt_for_token could be used as a final fallback.

Describe alternatives you've considered
The obvious solution is to implement the above in my own code. However, I believe it is a common enough use-case to justify putting a convenience method in rspotify. Why have everyone duplicating effort.

Additional context
Willing to implement this (I will have to do it for my program anyway.) Open to suggestions on what http server crate to use.

@blueforesticarus blueforesticarus added the enhancement New feature or request label May 26, 2023
@ramsayleung
Copy link
Owner

I think this issue is similar with this discussion: #365

Copy link

Message to comment on stale issues. If none provided, will not mark issues stale

@github-actions github-actions bot added the Stale label Nov 23, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 8, 2023
@ramsayleung ramsayleung removed the Stale label Dec 8, 2023
@ramsayleung ramsayleung reopened this Dec 8, 2023
@gdesmott
Copy link
Contributor

A convenience method like prompt_for_token but which spins up a local server listening to the redirect url, using it to get the code semi-automatically.

librespot-oauth is doing exactly that: https://github.com/librespot-org/librespot/blob/dev/oauth/src/lib.rs

@ramsayleung
Copy link
Owner

Closing this ticket as this feature has been implemented in this PR: #513

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants