Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Deprecate Weave CNI plugin #9556

Closed
gaktive opened this issue Aug 16, 2023 · 8 comments
Closed

Deprecate Weave CNI plugin #9556

gaktive opened this issue Aug 16, 2023 · 8 comments
Assignees
Labels
ember Ember UI Issue kind/enhancement QA/XS size/2 Size Estimate 2 team/area2 Hostbusters
Milestone

Comments

@gaktive
Copy link
Member

gaktive commented Aug 16, 2023

Internal reference: SURE-6793

It was agreed to deprecate Weave in RKE 1.27 for different reasons:
1 - Weave has not released a new version since Jan 2021
2 - Weave is not supported in rke2/k3s, i.e. no migration path
3 - Apparently, no one is really using weave CNI plugin

Deprecating Weave in RKE 1.27 will mean adding a warning in the logs and in the flags that states "Weave is deprecated and will be removed in 1.30".

@manuelbuil will take care of showing the warning message in the code of rke but he needs that message to be included in the UI too, i.e. when a rke downstream user is creating the cluster, when selecting Weave, it should see the deprecation warning.

@richard-cox
Copy link
Member

plugins are handled as helm charts listed per kube version in the responses to v1-rke2-release/releases and v1-k3s-release/releases

@nwmac
Copy link
Member

nwmac commented Sep 1, 2023

@gaktive This is RKE1, so Ember, right? I only see Weave as an option for RKE1.

@markusewalker
Copy link

QA TEST PLAN

Scenarios

Scenario Test Case
1 As a standard user, provision an RKE1 downstream node driver v1.27 cluster w/Weave CNI, validate that a banner appears
2 As a standard user, provision an RKE1 downstream node driver v1.26 cluster w/Weave CNI, validate that no banner appears

@markusewalker
Copy link

Validated that this is addressed in v2.8-head rancher/rancher@595b76a.

ENVIRONMENT DETAILS

TEST RESULT

Scenario Test Case Result
1 As a standard user, provision an RKE1 downstream node driver v1.27 cluster w/Weave CNI, validate that a banner appears
2 As a standard user, provision an RKE1 downstream node driver v1.26 cluster w/Weave CNI, validate that no banner appears

VALIDATION STEPS

Scenario 1

  1. As a standard user, provisioned a downstream RKE1 v1.27.5-rancher1-1 with Weave as the CNI.
    • Noted the following warning message:
image 2. Validated that the cluster and nodes successfully came up as `Active` in Cluster Management and Cluster Explorer.

Scenario 2

  1. Repeated scenario, but provisioned a downstream RKE1 v1.26.8-rancher1-1 with Weave as the CNI.

@manuelbuil
Copy link

Awesome! rke code also includes now the warning!

@nwmac
Copy link
Member

nwmac commented Sep 22, 2023

@manuelbuil Does that have an automated test, or has that been manually QA-ed?

@manuelbuil
Copy link

@manuelbuil Does that have an automated test, or has that been manually QA-ed?

Automated test sounds like too much for a log entry. I manually tested it and hopefully QA will do it as well. The QA procedure for rke1 is still in the works

@zube zube bot removed the [zube]: Done label Dec 21, 2023
@rancher rancher deleted a comment from github-actions bot Jan 18, 2024
@rancher rancher deleted a comment from github-actions bot Jan 18, 2024
@mantis-toboggan-md
Copy link
Member

/backport v.2.7.next1

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
ember Ember UI Issue kind/enhancement QA/XS size/2 Size Estimate 2 team/area2 Hostbusters
Projects
None yet
Development

No branches or pull requests

8 participants