-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Deprecate Weave CNI plugin #9556
Comments
plugins are handled as helm charts listed per kube version in the responses to |
@gaktive This is RKE1, so Ember, right? I only see Weave as an option for RKE1. |
QA TEST PLAN Scenarios
|
Validated that this is addressed in ENVIRONMENT DETAILS
TEST RESULT
VALIDATION STEPS Scenario 1
![]() Scenario 2
|
Awesome! rke code also includes now the warning! |
@manuelbuil Does that have an automated test, or has that been manually QA-ed? |
Automated test sounds like too much for a log entry. I manually tested it and hopefully QA will do it as well. The QA procedure for rke1 is still in the works |
/backport v.2.7.next1 |
Internal reference: SURE-6793
It was agreed to deprecate Weave in RKE 1.27 for different reasons:
1 - Weave has not released a new version since Jan 2021
2 - Weave is not supported in rke2/k3s, i.e. no migration path
3 - Apparently, no one is really using weave CNI plugin
Deprecating Weave in RKE 1.27 will mean adding a warning in the logs and in the flags that states "Weave is deprecated and will be removed in 1.30".
@manuelbuil will take care of showing the warning message in the code of rke but he needs that message to be included in the UI too, i.e. when a rke downstream user is creating the cluster, when selecting Weave, it should see the deprecation warning.
The text was updated successfully, but these errors were encountered: