Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[FEA] Improve escape character and quotation character parsing in Json and CSV reader. #6305

Closed
rgsl888prabhu opened this issue Sep 23, 2020 · 3 comments
Labels
cuIO cuIO issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. Performance Performance related issue

Comments

@rgsl888prabhu
Copy link
Contributor

rgsl888prabhu commented Sep 23, 2020

Is your feature request related to a problem? Please describe.
As of now, csv and json reader are post processing occurrences of escape character and quotation character once it parses complete string.

out_columns.emplace_back(

Describe the solution you'd like
We might be able to handle skipping/leaving those character while copying the data.

@harrism
Copy link
Member

harrism commented Sep 29, 2020

Can you clarify the title of this issue to indicate which cuIO reader and writer?

@rgsl888prabhu rgsl888prabhu changed the title [FEA] Improve escape character and quotation character parsing in cuio reader and writer [FEA] Improve escape character and quotation character parsing in Json and CSV reader. Sep 29, 2020
@github-actions
Copy link

This issue has been marked rotten due to no recent activity in the past 90d. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.

@vuule vuule added the Performance Performance related issue label Jan 9, 2023
@vuule vuule added this to the Modernize CSV reader milestone Jan 9, 2023
@GregoryKimball GregoryKimball added libcudf Affects libcudf (C++/CUDA) code. and removed inactive-90d labels Apr 2, 2023
@karthikeyann
Copy link
Contributor

This issue is not relevant for JSON reader anymore. JSON reader string processing performance escape characters and also utf8 decoding properly. if CSV reader does not have this issue, this issue can be closed.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
cuIO cuIO issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. Performance Performance related issue
Projects
None yet
Development

No branches or pull requests

5 participants