Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[BUG] cuIndicator.ipynb - Incorrect path to dataset #13

Closed
miguelusque opened this issue Aug 5, 2019 · 2 comments
Closed

[BUG] cuIndicator.ipynb - Incorrect path to dataset #13

miguelusque opened this issue Aug 5, 2019 · 2 comments
Assignees
@miguelusque
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@miguelusque
Copy link
Contributor

Hi,

It seems that the path to the datasets is incorrect at cuIndicator.ipynb notebook.

Currently, it is defined as follows:
"path": "/Project/data/stocks/stock_price_hist.csv.gz"

I think it should be:
"path": "../data/stock_price_hist.csv.gz"

Something similar is happening with the following dataset:
"path": "/Project/data/stocks/security_master.csv.gz"

Hope it helps!

Miguel
@miguelusque miguelusque self-assigned this Aug 5, 2019
@miguelusque miguelusque added bug Something isn't working good first issue Good for newcomers labels Aug 5, 2019
@yidong72
Copy link
Collaborator

yidong72 commented Aug 5, 2019

Yes. it is a bug we need to fix.
Can you help with it? @miguelangel
Maybe you can fix this with this issue together in one PR?

@miguelusque
Copy link
Contributor Author

Sure thing! I'll deal with it.

miguelusque added a commit that referenced this issue Aug 5, 2019
@miguelusque
Fix issues #13, #14, and #15
a7288ed
miguelusque added a commit to tensorflowfd/rapids-gQuant that referenced this issue Aug 5, 2019
@miguelusque
Fix issues NVIDIA#13, NVIDIA#14, and NVIDIA#15
801c7e8
@miguelusque miguelusque mentioned this issue Aug 5, 2019
Merged
yidong72 added a commit that referenced this issue Aug 6, 2019
@yidong72
Merge pull request #18 from miguelangel/fix-13-14-15
e1f2df9 
Fix issues #13, #14, #16 in cuIndicator.ipynb notebook
@yidong72 yidong72 closed this as completed Aug 6, 2019
@avolkov1 avolkov1 mentioned this issue Jul 10, 2020
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@miguelusque miguelusque

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@miguelusque @yidong72