Fix #39 - Refactor 04_portfolio_trade.ipynb notebook #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yidong72
requested changes
Aug 16, 2019
miguelusque
commented
Aug 16, 2019
There was a problem hiding this comment.
Hi Yi,
I have completed everything but this one:
we want to point out the user needs to set "self.delayed_process = True" to enable this dask computation graph integration.
Could you please write the complete sentence? I cannot see either where that comment should be.
Thanks!
|
added my comments there |
|
Submitted a new commit with the latest changes requested. |
Merged
miguelusque
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
04_portfolio_trade notebook refacturing.
Any comments are welcomed!