Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[REVIEW] change the text for notebook 05 #55

Merged
merged 3 commits into from
Aug 29, 2019

Conversation

yidong72
Copy link
Collaborator

Changed the text a bit for notebook 05

@yidong72 yidong72 requested a review from avolkov1 August 26, 2019 14:47
@miguelusque
Copy link
Contributor

Hi,

I think we should avoid some words as ‘framework’ or library.

@avolkov1
Copy link
Contributor

Hi,

I think we should avoid some words as ‘framework’ or library.

It is what it is.

@yidong72
Copy link
Collaborator Author

I take out the framework to make it less sensitive

Copy link
Contributor

@avolkov1 avolkov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Do you want to add a simple example for grouping tasks with a custom node? Or leave that for later? Otherwise I can merge this.

@yidong72
Copy link
Collaborator Author

Looks good now. Do you want to add a simple example for grouping tasks with a custom node? Or leave that for later? Otherwise I can merge this.

We need a dedicated group node to handle the type checks. Let's do it in a different PR

@avolkov1 avolkov1 merged commit a0cd5ef into NVIDIA:develop Aug 29, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants