Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[REVIEW]Feature adding fractional differencing computation #56

Merged
merged 11 commits into from
Sep 9, 2019

Conversation

yidong72
Copy link
Collaborator

@yidong72 yidong72 commented Sep 5, 2019

This is to address this issue by adding fractional differencing computation. It is not finished yet but the main computation functions are implemented with the unittests. It can start the review process. I am going to add computation node and python notebooks in the next commit.

@yidong72 yidong72 requested a review from avolkov1 September 5, 2019 20:54
@yidong72 yidong72 changed the title [WIP]Feature adding fractional differencing computation [REVIEW]Feature adding fractional differencing computation Sep 6, 2019
@yidong72
Copy link
Collaborator Author

yidong72 commented Sep 6, 2019

The new notebook is added. It is ready to review.

Copy link
Contributor

@avolkov1 avolkov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor remarks. I'm still running the notebook. Looks good though.

@yidong72
Copy link
Collaborator Author

yidong72 commented Sep 7, 2019

All the review points are addressed

Copy link
Contributor

@avolkov1 avolkov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me. My only suggestion would be to unpack the tuple at the end of the notebook explicitly. Like this:

(lineplot,) = task_graph.run(
    outputs=outlist,
    replace=replace_spec)

# display plot in jupyter
lineplot

Instead of

o_gpu = task_graph.run(
            outputs=outlist,
            replace=replace_spec)
o_gpu[0]

It wasn't clear to me at first that o_gpu contained the figure plot that was being displayed even though it was discussed in the preceding cells of the notebook.

That would be the only change I would suggest. If you want to make this change let me know, otherwise I'll merge this.

@yidong72
Copy link
Collaborator Author

yidong72 commented Sep 9, 2019

I did the changes in the notebook. Ready to get it merged.

@avolkov1 avolkov1 added the enhancement New feature or request label Sep 9, 2019
@avolkov1 avolkov1 merged commit 7b69274 into NVIDIA:develop Sep 9, 2019
@yidong72 yidong72 deleted the feature-fraction-diff branch September 9, 2019 19:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants