-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[REVIEW]Feature adding fractional differencing computation #56
Conversation
The new notebook is added. It is ready to review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor remarks. I'm still running the notebook. Looks good though.
All the review points are addressed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me. My only suggestion would be to unpack the tuple at the end of the notebook explicitly. Like this:
(lineplot,) = task_graph.run(
outputs=outlist,
replace=replace_spec)
# display plot in jupyter
lineplot
Instead of
o_gpu = task_graph.run(
outputs=outlist,
replace=replace_spec)
o_gpu[0]
It wasn't clear to me at first that o_gpu
contained the figure plot that was being displayed even though it was discussed in the preceding cells of the notebook.
That would be the only change I would suggest. If you want to make this change let me know, otherwise I'll merge this.
I did the changes in the notebook. Ready to get it merged. |
This is to address this issue by adding fractional differencing computation. It is not finished yet but the main computation functions are implemented with the unittests. It can start the review process. I am going to add computation node and python notebooks in the next commit.