Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Feature indicator node #8

Merged
merged 7 commits into from
Jul 17, 2019
Merged

Feature indicator node #8

merged 7 commits into from
Jul 17, 2019

Conversation

yidong72
Copy link
Collaborator

add the indicator node to help create features for ML algorithms.

@yidong72 yidong72 requested a review from avolkov1 July 12, 2019 19:59
avolkov1
avolkov1 reviewed Jul 16, 2019
View reviewed changes
Copy link
Contributor

@avolkov1 avolkov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the unit tests passed. I manually ran flake8 on all modified files. Just a few comments to resolve and I'll merge.

@yidong72
Copy link
Collaborator Author

the flake8 error is fixed and removed another unused constant.

@yidong72
Copy link
Collaborator Author

doc str is fixed too

avolkov1
avolkov1 approved these changes Jul 17, 2019
View reviewed changes
Copy link
Contributor

@avolkov1 avolkov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll merge.

@avolkov1 avolkov1 merged commit 0a6e5ee into NVIDIA:develop Jul 17, 2019
@yidong72 yidong72 deleted the feature-indicator-node branch August 5, 2019 15:23
@avolkov1 avolkov1 mentioned this pull request Jul 10, 2020
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@avolkov1 avolkov1 avolkov1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yidong72 @avolkov1