Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Integrate LunarSky module to do sensitivy predictions for array on the moon #32

Open
steven-murray opened this issue Aug 6, 2020 · 3 comments
Assignees

Comments

@steven-murray
Copy link
Contributor

This uses @aelanman's LunarSky. @jpober suggests this.

@jpober
Copy link
Contributor

jpober commented Jun 3, 2022

This might be as simple as switching _utils line 140 to a MoonLocation object provided by lunarsky. I will test at some point!

@jpober
Copy link
Contributor

jpober commented Oct 18, 2022

Looks like we also need to change line 226 in observatory.py to update obs_duration for lunar days (as opposed to earth days). That will likely also cause other consistency checks to fail (e.g. line 94 in observation.py that insists obs_duration be less than 24 hours)

@steven-murray
Copy link
Contributor Author

That makes sense. We could generalize that easily.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants