Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix #250: introduce tmpdir option for overriding the system tmp dir #252

Merged
merged 1 commit into from
Apr 28, 2020

Conversation

silkentrance
Copy link
Collaborator

@silkentrance silkentrance commented Apr 28, 2020

fix #250: introduce tmpdir option for overriding the system tmp dir

also fix issue with changes to the options leaking out, now copying the options to a new object

@silkentrance silkentrance force-pushed the gh-250 branch 2 times, most recently from 00877fa to d83dd7b Compare April 28, 2020 17:39
@silkentrance silkentrance requested a review from raszi April 28, 2020 17:39
@silkentrance silkentrance mentioned this pull request Apr 28, 2020
8 tasks
@silkentrance silkentrance force-pushed the gh-250 branch 3 times, most recently from 1494574 to b67f63d Compare April 28, 2020 19:12
@silkentrance
Copy link
Collaborator Author

A new release needs to be made available with an updated version of the changelog.

See the instructions in #253 on how to do that.

@silkentrance silkentrance merged commit 598a36f into master Apr 28, 2020
@silkentrance silkentrance deleted the gh-250 branch April 28, 2020 20:47
@silkentrance
Copy link
Collaborator Author

@raszi I have already bumped the version and updated the changelog. Have fun releasing 0.2.1 :)

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

should not lock dir in os.tmp
2 participants