perf(block): use Block::bordered #1041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdJoPaTo
requested review from
orhun,
mindoodoo,
sayanarijit,
joshka,
kdheepak and
Valentin271
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1041 +/- ##
=======================================
- Coverage 89.4% 89.4% -0.1%
=======================================
Files 61 61
Lines 15468 15440 -28
=======================================
- Hits 13839 13808 -31
- Misses 1629 1632 +3 ☔ View full report in Codecov by Sentry. |
EdJoPaTo
force-pushed
the
block-bordered
branch
from
83744a7 to
c7c27f3
Compare
|
There seems to be some usages left in |
|
README, good call! I only checked *.rs files to prevent CHANGELOG.md mishaps 😇 And… I think I got them all now? |
EdJoPaTo
force-pushed
the
block-bordered
branch
from
557c550 to
53af5a6
Compare
new can be const also realign methods to have the const first then alpabetically.
joshka
approved these changes
May 2, 2024
|
Thanks for keeping the block tests in. LGTM |
joshka
pushed a commit
to nowNick/ratatui
that referenced
this pull request
May 24, 2024
`Block::bordered()` is shorter than `Block::new().borders(Borders::ALL)`, requires one less import (`Borders`) and in case `Block::default()` was used before can even be `const`.
joshka
pushed a commit
to erak/ratatui
that referenced
this pull request
Oct 14, 2024
`Block::bordered()` is shorter than `Block::new().borders(Borders::ALL)`, requires one less import (`Borders`) and in case `Block::default()` was used before can even be `const`.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Block::bordered()is shorter thanBlock::new().borders(Borders::ALL), requires one less import (Borders) and in caseBlock::default()was used before can even beconst.This mostly changes examples, documentation, and tests.
As I used a lot of regular expressions I could have overlooked something when checking all the changes myself. Another set of eyes might find something I missed.