perf(layout): avoid allocating memory when using split ergonomic utils #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tranzystorekk
requested review from
orhun,
joshka,
kdheepak,
Valentin271 and
EdJoPaTo
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1105 +/- ##
=====================================
Coverage 94.2% 94.2%
=====================================
Files 61 61
Lines 14587 14587
=====================================
Hits 13751 13751
Misses 836 836 ☔ View full report in Codecov by Sentry. |
EdJoPaTo
reviewed
May 13, 2024
kdheepak
approved these changes
May 13, 2024
EdJoPaTo
approved these changes
May 13, 2024
joshka
pushed a commit
to nowNick/ratatui
that referenced
this pull request
May 24, 2024
ratatui#1105) Don't create intermediate vec in `Layout::areas` and `Layout::spacers` when there's no need for one.
joshka
pushed a commit
to erak/ratatui
that referenced
this pull request
Oct 14, 2024
ratatui#1105) Don't create intermediate vec in `Layout::areas` and `Layout::spacers` when there's no need for one.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed we create an intermediate vec in
Layout::areasandLayout::spacersbut there's no need for one.