Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Benchmark for React is wrong, you run React in a dev mode #2

Closed
istarkov opened this issue Jan 13, 2017 · 2 comments
Closed

Benchmark for React is wrong, you run React in a dev mode #2

istarkov opened this issue Jan 13, 2017 · 2 comments

Comments

@istarkov
Copy link

Just add NODE_ENV=production to server build webpack config

  plugins: [
    new webpack.DefinePlugin({
      'process.env': {
        NODE_ENV: '"production"'
      }
    })
  ]

And run test as
NODE_ENV=production node ./renderToString.js

And you will get near same timings

rx: 56.581ms
react: 85.216ms
@yyx990803
Copy link
Contributor

FYI this is addressed in #3 ;)

@istarkov
Copy link
Author

Having that #3 is merged, can be closed

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants