Add tolerance option #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #16 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 68 69 +1
=========================================
+ Hits 68 69 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
rbardini
requested changes
Mar 19, 2023
bin/jest-it-up
Outdated
| @@ -7,6 +7,12 @@ const jestItUp = require('../lib') | |||
| program | |||
| .option('-c, --config <path>', 'path to a Jest config file', 'jest.config.js') | |||
| .option('-m, --margin <margin>', 'minimum threshold increase', parseFloat, 0) | |||
| .option( | |||
| '-t, --tolerance <tolerance>', | |||
| 'keeps the new threshold below the current coverage', | |||
There was a problem hiding this comment.
I'd prefer to describe the option value instead:
Suggested change
| 'keeps the new threshold below the current coverage', | |
| 'threshold difference from actual coverage', |
Please remember to update the README accordingly—I recommend running jest-it-up --help and copy-pasting the output there.
JCorpe26
force-pushed
the
add-tolerance-option
branch
from
582305c to
25af4d9
Compare
|
@rbardini Fair shout, I have updated this :) 🤞 Should be all good now |
rbardini
approved these changes
Mar 26, 2023
|
🎉 This PR is included in version 2.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to provide a tolerance amount to allow a bit of wiggle room for the new coverage. So it isn't updated to the exact amount.