Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: handle raw: true option to pass form submission values correctly #733

Merged
merged 4 commits into from
Jan 30, 2025

Conversation

jorisre
Copy link
Member

@jorisre jorisre commented Jan 28, 2025

Ensure that the raw: true option in the Resolver now correctly passes a copy of the form submission values, preventing data loss or inconsistencies.

Fixes #718

@bluebill1049 Review is welcome, but please don’t merge. Thank you!

…es correctly

Ensure that the `raw: true` option in the Resolver now correctly passes a copy of the form submission values, preventing data loss or inconsistencies.
@jorisre jorisre requested a review from bluebill1049 January 28, 2025 11:25
Copy link
Contributor

github-actions bot commented Jan 28, 2025

Size Change: +178 B (+0.57%)

Total Size: 31.6 kB

Filename Size Change
arktype/dist/arktype.js 311 B +5 B (+1.63%)
arktype/dist/arktype.module.js 326 B +5 B (+1.56%)
arktype/dist/arktype.umd.js 413 B +5 B (+1.23%)
class-validator/dist/class-validator.module.js 562 B +2 B (+0.36%)
class-validator/dist/class-validator.umd.js 642 B +2 B (+0.31%)
superstruct/dist/superstruct.js 339 B +15 B (+4.63%) 🔍
superstruct/dist/superstruct.module.js 356 B +13 B (+3.79%)
superstruct/dist/superstruct.umd.js 437 B +13 B (+3.07%)
typeschema/dist/typeschema.js 479 B +11 B (+2.35%)
typeschema/dist/typeschema.module.js 491 B +11 B (+2.29%)
typeschema/dist/typeschema.umd.js 586 B +10 B (+1.74%)
valibot/dist/valibot.js 477 B +2 B (+0.42%)
valibot/dist/valibot.module.js 493 B +4 B (+0.82%)
valibot/dist/valibot.umd.js 586 B +3 B (+0.51%)
vine/dist/vine.js 543 B +11 B (+2.07%)
vine/dist/vine.module.js 553 B +11 B (+2.03%)
vine/dist/vine.umd.js 648 B +9 B (+1.41%)
yup/dist/yup.js 626 B +4 B (+0.64%)
yup/dist/yup.module.js 641 B +5 B (+0.79%)
yup/dist/yup.umd.js 730 B +4 B (+0.55%)
zod/dist/zod.js 611 B +12 B (+2%)
zod/dist/zod.module.js 629 B +11 B (+1.78%)
zod/dist/zod.umd.js 713 B +10 B (+1.42%)
ℹ️ View Unchanged
Filename Size
ajv/dist/ajv.js 692 B
ajv/dist/ajv.module.js 646 B
ajv/dist/ajv.umd.js 803 B
class-validator/dist/class-validator.js 537 B
computed-types/dist/computed-types.js 385 B
computed-types/dist/computed-types.module.js 401 B
computed-types/dist/computed-types.umd.js 476 B
dist/resolvers.js 446 B
dist/resolvers.module.js 454 B
dist/resolvers.umd.js 537 B
effect-ts/dist/effect-ts.js 442 B
effect-ts/dist/effect-ts.module.js 458 B
effect-ts/dist/effect-ts.umd.js 545 B
fluentvalidation-ts/dist/fluentvalidation-ts.js 488 B
fluentvalidation-ts/dist/fluentvalidation-ts.module.js 508 B
fluentvalidation-ts/dist/fluentvalidation-ts.umd.js 575 B
io-ts/dist/io-ts.js 1.27 kB
io-ts/dist/io-ts.module.js 1.15 kB
io-ts/dist/io-ts.umd.js 1.39 kB
joi/dist/joi.js 590 B
joi/dist/joi.module.js 606 B
joi/dist/joi.umd.js 694 B
nope/dist/nope.js 347 B
nope/dist/nope.module.js 366 B
nope/dist/nope.umd.js 435 B
typanion/dist/typanion.js 329 B
typanion/dist/typanion.module.js 344 B
typanion/dist/typanion.umd.js 425 B
typebox/dist/typebox.js 501 B
typebox/dist/typebox.module.js 518 B
typebox/dist/typebox.umd.js 616 B
vest/dist/vest.js 479 B
vest/dist/vest.module.js 443 B
vest/dist/vest.umd.js 568 B

compressed-size-action

@jorisre jorisre merged commit 7807f95 into master Jan 30, 2025
4 checks passed
@ben-reitz
Copy link

Thanks so much for putting in the time and effort to fix this @jorisre 🙏🏼

@jorisre jorisre deleted the fix/resolver-raw-true-form-values branch January 30, 2025 13:05
Copy link
Contributor

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

raw: true option on ZodResolver not passing copy of form submission values
3 participants