Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: support passing view props #693

Merged
merged 1 commit into from
Nov 15, 2022
Merged

feat: support passing view props #693

merged 1 commit into from
Nov 15, 2022

Conversation

vonovak
Copy link
Member

@vonovak vonovak commented Nov 15, 2022

Summary

this adds support for onLayout and potentially other props which previously were not passed to the native component on ios.

Test Plan

tested locally

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS Implemented
iOS
Android

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)
  • I have added automated tests, either in JS or e2e tests, as applicable

@vonovak vonovak enabled auto-merge (squash) November 15, 2022 16:08
@vonovak vonovak disabled auto-merge November 15, 2022 16:08
@vonovak vonovak enabled auto-merge (squash) November 15, 2022 16:08
@vonovak vonovak merged commit 2e6504f into master Nov 15, 2022
@vonovak vonovak deleted the feat/more-props branch November 15, 2022 16:28
vonovak pushed a commit that referenced this pull request Nov 15, 2022
# [6.7.0](v6.6.0...v6.7.0) (2022-11-15)

### Features

* **ios:** support passing view props ([#693](#693)) ([2e6504f](2e6504f))
@vonovak
Copy link
Member Author

vonovak commented Nov 15, 2022

🎉 This issue has been resolved in version 6.7.0 🎉

If this package helps you, consider sponsoring us! 🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant