Skip to content

Duplicated methods #829

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
Tpgainz opened this issue Feb 9, 2025 · 2 comments
Open

Duplicated methods #829

Tpgainz opened this issue Feb 9, 2025 · 2 comments

Comments

@Tpgainz
Copy link

Tpgainz commented Feb 9, 2025

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch react-native-callkeep@4.3.16 for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-callkeep/android/src/main/java/io/wazo/callkeep/RNCallKeepModule.java b/node_modules/react-native-callkeep/android/src/main/java/io/wazo/callkeep/RNCallKeepModule.java
index 025480a..180dd47 100644
--- a/node_modules/react-native-callkeep/android/src/main/java/io/wazo/callkeep/RNCallKeepModule.java
+++ b/node_modules/react-native-callkeep/android/src/main/java/io/wazo/callkeep/RNCallKeepModule.java
@@ -434,10 +434,10 @@ public class RNCallKeepModule extends ReactContextBaseJavaModule implements Life
         this.hasListeners = false;
     }
 
-    @ReactMethod
-    public void displayIncomingCall(String uuid, String number, String callerName) {
-        this.displayIncomingCall(uuid, number, callerName, false, null);
-    }
+    // @ReactMethod
+    // public void displayIncomingCall(String uuid, String number, String callerName) {
+    //     this.displayIncomingCall(uuid, number, callerName, false, null);
+    // }
 
     @ReactMethod
     public void displayIncomingCall(String uuid, String number, String callerName, boolean hasVideo) {
@@ -488,10 +488,10 @@ public class RNCallKeepModule extends ReactContextBaseJavaModule implements Life
         this.startCall(uuid, number, callerName, false, null);
     }
 
-    @ReactMethod
-    public void startCall(String uuid, String number, String callerName, boolean hasVideo) {
-        this.startCall(uuid, number, callerName, hasVideo, null);
-    }
+    // @ReactMethod
+    // public void startCall(String uuid, String number, String callerName, boolean hasVideo) {
+    //     this.startCall(uuid, number, callerName, hasVideo, null);
+    // }
 
     public void startCall(String uuid, String number, String callerName, boolean hasVideo, @Nullable Bundle payload) {
         Log.d(TAG, "[RNCallKeepModule] startCall called, uuid: " + uuid + ", number: " + number + ", callerName: " + callerName + ", payload: " + payload);

This issue body was partially generated by patch-package.

@mister-mohit
Copy link

--- a/node_modules/react-native-callkeep/android/src/main/java/io/wazo/callkeep/RNCallKeepModule.java
+++ b/node_modules/react-native-callkeep/android/src/main/java/io/wazo/callkeep/RNCallKeepModule.java
where i can find this line to change.

@Tpgainz
Copy link
Author

Tpgainz commented Feb 25, 2025

In your own /node_modules/react-native-callkeep/android/src/main/java/io/wazo/callkeep/RNCallKeepModule.java. Ensure you properly installed RNCallKeep

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants