-
-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Typescript support for defining component Interface through React interface #387
Comments
Any guidance on this please? I'd be happy to take a look and create an MR for this if pointed in the right direction / is it something on your roadmap. |
@johnnycopperstone I think the problem somewhere in this module https://github.com/reactjs/react-docgen/blob/e05219b08c8b17899be812a521b4985f2b66fae2/src/utils/isStatelessComponent.js You can debug it with |
The playground parses the code with flow enabled, but not sure if it would work if it gets parsed as typescript. |
The |
I just checked again and the problem is only happening when the Props are only defined in the Will look into this soon. |
Coming here from storybook migration guide to 6.0. This is how we define our components so will wait on this to be resolved, rather than re-writing all our components. Unfortunately I'm not able to help with a fix for the issue. Thanks in advance to whoever does :) |
I hope it might help as temporary workaround - I made a custom handler for parsing React.FC < Props >, which points at existing Props at UI-component. |
Keeping my eye on this @danez , 6.0 is looking great so far :) |
I'm playing around with the playground and noticed that if you type your component in this way
const MyComponent: React.FC<IProps> = ..
, react-docgen doesn't pick up the interface inIProps
.I'm curious to know if there's a specific reason for this, and if support for this might be on the roadmap.
Thanks!
The text was updated successfully, but these errors were encountered: