Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix vcs_pageview_mode #1010

Merged
merged 3 commits into from
Nov 25, 2020
Merged

Fix vcs_pageview_mode #1010

merged 3 commits into from
Nov 25, 2020

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Oct 8, 2020

Fixes #701

This was referenced Oct 8, 2020
Closed
Open
Blendify
Blendify reviewed Oct 8, 2020
View reviewed changes
Copy link
Member

@Blendify Blendify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason https://jinja.palletsprojects.com/en/2.11.x/templates/#default does not work here?

@stsewd
Copy link
Member Author

stsewd commented Oct 8, 2020

@Blendify the value is defined as empty so it doesn't work with default

Blendify
Blendify approved these changes Nov 25, 2020
View reviewed changes
Copy link
Member

@Blendify Blendify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@stsewd stsewd merged commit 38752d4 into master Nov 25, 2020
@stsewd stsewd deleted the fix-vcs-pageview-mode branch November 25, 2020 22:39
jasongrout added a commit to jasongrout/jupyterlab that referenced this pull request Jan 8, 2021
@jasongrout
Fix breadcrumb links.
e49891a 
See readthedocs/sphinx_rtd_theme#1010
@jasongrout jasongrout mentioned this pull request Jan 8, 2021
Merged
@JulianGro JulianGro mentioned this pull request Feb 2, 2021
Closed
JulianGro added a commit to JulianGro/vircadia-docs-sphinx that referenced this pull request Feb 2, 2021
@JulianGro
Fix vcs_pageview_mode default according to upstream. See readthedocs/…
87d49a6 
…sphinx_rtd_theme#1010
@JulianGro JulianGro mentioned this pull request Feb 2, 2021
Merged
sdhiscocks added a commit to dstl/Stone-Soup that referenced this pull request Feb 16, 2021
@sdhiscocks
Fix Edit on GitHub links on documentation.
0a7c04b 
Fix inline with changes on the theme. See: readthedocs/sphinx_rtd_theme#1010
@sdhiscocks sdhiscocks mentioned this pull request Feb 16, 2021
Merged
This was referenced Mar 14, 2021
Closed
Closed
Merged
@kwkbtr kwkbtr mentioned this pull request May 12, 2021
Merged
PhilClemson pushed a commit to PhilClemson/Stone-Soup-1 that referenced this pull request Oct 26, 2021
@sdhiscocks @PhilClemson
Fix Edit on GitHub links on documentation.
10c457f 
Fix inline with changes on the theme. See: readthedocs/sphinx_rtd_theme#1010
mikee47 added a commit to mikee47/Sming that referenced this pull request Dec 8, 2021
@mikee47
Fix pageview mode
11c4160 
Broken by readthedocs/sphinx_rtd_theme#1010
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Blendify Blendify Blendify approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vcs_pageview_mode template parameter is not recognised
2 participants
@stsewd @Blendify