[C] Fix aeron_randomised_int32 on Windows #854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rand() was not seeded and always produced the same sequence - rand() * INT_MAX would always cause an overflow - Use rand_s instead of rand for better randomness and to avoid the dependency on a seed
|
Will merge once checks pass. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The media driver always produced the same sequence of session IDs.
rand()was apparently not seeded properly (yet it should have been, I need to check why)rand() * INT_MAXwould always cause an overflowrand_sinstead ofrandfor better randomness and to avoid the dependency on a seed (it better aligns to what is done on other platforms)