syntactic_sugar message should be type specific

[freak4pc]

New Issue Checklist

• Updated SwiftLint to the latest version
• I searched for existing GitHub issues

Bug Report

Environment

• SwiftLint version (run swiftlint version to be sure)? 0.21.0

• Installation method used (Homebrew, CocoaPods, building from source, etc)? CocoaPods

• Are you using nested configurations? No

• Which Xcode version are you using (check xcode-select -p)? 8.3.3

• Do you have a sample that shows the issue?

$ echo "func filterNil<T>() -> Observable<T> where E == Optional<T> {" | swiftlint lint --no-cache --use-stdin --enable-all-rules

<nopath>:1:49: warning: Syntactic Sugar Violation: Shorthand syntactic sugar should be used, i.e. [Int] instead of Array<Int> (syntactic_sugar)

[marcelofabri]

It's not complaining about an array, it's because of Optional<T>. Can you try changing to T??.

Anyway, we probably should be more specific on the message 👍

[freak4pc]

That solves it ! Thanks @marcelofabri !
It's interesting it warns about an array syntax in that case :)

Should I close it or do you want to use this to track fixing up the message?

[marcelofabri]

Yeah, we use the same message no matter the type currently. Let's keep it open to track enhancing the message 💯