Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Be able to configure parameters of ParameterizedRules through the configuration file #26

Closed
aarondaub opened this issue May 22, 2015 · 6 comments

Comments

@aarondaub
Copy link

No description provided.

@chriseidhof
Copy link
Contributor

Hey @jpsim any thoughts on this? I'd really like to make rules configurable as well, I have different ideas about some of the default settings. Would be interested in working on this!

@jpsim
Copy link
Collaborator

jpsim commented May 29, 2015

hmm, I haven't thought about this too much. I think ParameterizedRule could declare init(parameters: [RuleParameter]), we could add a Configuration struct with init(file: String) that would parse a YAML .travis.yml file as mentioned in #3.

I worked a bit on partial per-region application of configurations in the jp-configuration branch, but that's just a rough proof of concept.

I know @aarondaub has worked on this a bit in #24 and aarondaub#3 too.

@jpsim
Copy link
Collaborator

jpsim commented May 29, 2015

And then Linter could declare init(configuration:file:), and would initialize the rules accordingly.

@achansonjr
Copy link

Is there a branch of work under progress to try and implement this along with the desired design? I would be interested in contributing if theres a holistic design approach in mind. Would working with @aarondaub be a good starting point?

@jpsim
Copy link
Collaborator

jpsim commented Aug 28, 2015

I have a first draft version of this in #106 😄 .

@jpsim
Copy link
Collaborator

jpsim commented Nov 17, 2015

Done in #106.

@jpsim jpsim closed this as completed Nov 17, 2015
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants