Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

build(python): add support for Python 3.13 (#472) #472

Merged

Conversation

jlemesh
Copy link
Member

@jlemesh jlemesh commented Oct 9, 2024

Closes reanahub/reana#837

Add support for Python 3.13.

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@cf38a92). Learn more about missing BASE report.
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #472   +/-   ##
=========================================
  Coverage          ?   44.23%           
=========================================
  Files             ?       28           
  Lines             ?     1978           
  Branches          ?        0           
=========================================
  Hits              ?      875           
  Misses            ?     1103           
  Partials          ?        0           

@jlemesh jlemesh force-pushed the feature_add_support_for_python313 branch from b8e030d to 563f8c8 Compare October 10, 2024 07:08
@jlemesh jlemesh changed the title ci(actions): add support for python 3.13 (#472) build(python): add support for Python 3.13 (#472) Oct 10, 2024
Copy link
Member

@tiborsimko tiborsimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW locally I'm seeing:

$ pip install tox --upgrade
$ tox -e py313
...
      gcc -fno-strict-overflow -Wsign-compare -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DNDEBUG -fexceptions -fcf-protection -fexceptions -fcf-protection -fexceptions -fcf-protection -O3 -fPIC "-DPSYCOPG_VERSION=2.9.9 (dt dec pq3 ext lo64)" -DPSYCOPG_DEBUG=1 -DPG_VERSION_NUM=160004 -DHAVE_LO64=1 -DPSYCOPG_DEBUG=1 -I/home/tibor/private/project/reana/src/reana-commons/.tox/py313/include -I/usr/include/python3.13 -I. -I/usr/include -I/usr/include/pgsql/server -c psycopg/utils.c -o build/temp.linux-x86_64-cpython-313/psycopg/utils.o -Wdeclaration-after-statement
      psycopg/utils.c: In function ‘psyco_is_main_interp’:
      psycopg/utils.c:397:12: error: implicit declaration of function ‘_PyInterpreterState_Get’; did you mean ‘PyInterpreterState_Get’? [-Wimplicit-function-declaration]

but this should not be a blocker for merge since DB is not used much for the "client" side and Python 3.13 is used on the cluster side.

Besides, the CI is all green :)

@tiborsimko tiborsimko merged commit 563f8c8 into reanahub:master Oct 10, 2024
16 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: start testing Python 3.13
2 participants