Add codec for Js.Dict.t #48
Conversation
There was a problem hiding this comment.
Thanks for the contribution @jchavarri! Left a couple notes
| @@ -16,6 +16,7 @@ open Belt.Result; */ | |||
| [@decco] type l('a) = list('a); | |||
| [@decco] type o('a) = option('a); | |||
| [@decco] type r('v, 'e) = Belt.Result.t('v, 'e); | |||
| [@decco] type d('v) = Js.Dict.t('v); | |||
There was a problem hiding this comment.
Could you write tests that use this type? Or give me permission to push?
src/Decco.re
Outdated
|
|
||
| | (Ok(prev), Ok(newVal)) => prev->Belt.List.add((key, newVal))->Ok; | ||
| } | ||
| )->Belt.Result.map(Belt.List.toArray)->Belt.Result.map(Js.Dict.fromArray); |
There was a problem hiding this comment.
Instead of building a list, converting it to an array. and then converting that to a Js.Dict.t, how about using the reducer to build the Js.Dict.t directly?
Co-Authored-By: Ryan <rpbiwer@gmail.com>
…ating the initial value
|
@ryb73 thanks for the review :) I think I tackled all requests 👍 Do you mind taking another look please? Edit: regarding using arrays + lists to generate the new dict, I used them because |
|
Muchisimas gracias, @jchavarri! |
Fixes #4.