Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Raise minimum OCaml AST support #2496

Closed
ryyppy opened this issue Nov 21, 2019 · 2 comments
Closed

Raise minimum OCaml AST support #2496

ryyppy opened this issue Nov 21, 2019 · 2 comments

Comments

@ryyppy
Copy link
Contributor

ryyppy commented Nov 21, 2019

As far as I understand Migrate-Parse-Tree, Reason is currently running on the OCaml base version 4.04. The BuckleScript v7 release (also other tools like genType) will drop 4.02 support and there is no plan to support 4.04 whatsoever.

We are in the process of making refmt an integrated part of the BuckleScript Playground JS Bundle, so we strive to make the bundle as small and efficient as possible.

In our code review, @bobzhang stated: Is reason developed against 404? Maybe a good time to bump into 406 as well (see). Now this got me curious.

Are there many Reason consumers dependent on the 404 format? If not, would there be a chance to raise the minimum version to 4.06? As far as I understand MPT, this would speed up the convertion speed and reduce the executable / js bundle size if I am not mistaken?

If this is a silly request, feel free to close it. I couldn't find any information on Reason's OCaml support plans (except one very old discussion from 2017) and I am trying to get up to date context.

4.02 will definitely be obsolete, I guess this will make things easier in the Reason codebase as well?

@anmonteiro
Copy link
Member

related: #2036

@anmonteiro
Copy link
Member

Done in #2487

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants