Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add loader for xAIF graphs #20

Merged
merged 7 commits into from
Mar 18, 2023
Merged

Conversation

leonkamke
Copy link
Contributor

No description provided.

@mirkolenz mirkolenz self-requested a review March 14, 2023 07:00
Copy link
Member

@mirkolenz mirkolenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In principle, it looks good. Two remarks:

  • Please use lowercase for the xAIF files.
  • It seems that there is quite a bit of duplicate code now. Is it possible to reuse some of the AIF code for xAIF? I think that for instance the scheme parsing is identical.

@leonkamke
Copy link
Contributor Author

The Aif scheme in xAif is a little different than the "standalone" Aif scheme. So I think we should leave it like this.

@mirkolenz mirkolenz changed the title xAif Import feat: add loader for xAIF graphs Mar 18, 2023
@mirkolenz mirkolenz merged commit d91fa70 into recap-utr:main Mar 18, 2023
@github-actions
Copy link

🎉 This PR is included in version 1.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants