Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Staging to main: Prepare for release #2201

Merged
merged 7 commits into from
Dec 23, 2024
Merged

Staging to main: Prepare for release #2201

merged 7 commits into from
Dec 23, 2024

Conversation

miguelgfierro
Copy link
Collaborator

Description

Related Issues

References

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • I have signed the commits, e.g. git commit -s -m "your commit message".
  • This PR is being made to staging branch AND NOT TO main branch.

miguelgfierro and others added 7 commits November 17, 2024 07:56
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Update timeout of AzureML tests and add explicit runner in Ubuntu 24.04
Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Co-authored-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Co-authored-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
* Recommenders 1.2.1

Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>

* update readmes

Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>

* updating the date

---------

Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Co-authored-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
@miguelgfierro miguelgfierro merged commit 5c862af into main Dec 23, 2024
85 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 23, 2024
Staging to main: Prepare for release
@miguelgfierro
Copy link
Collaborator Author

I got an unexpected error after trying to : Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run. See https://github.com/recommenders-team/recommenders/actions/runs/12467800197/job/34799747313

@miguelgfierro
Copy link
Collaborator Author

I also got this error:

tests/unit/examples/test_notebooks_gpu.py .                              [ 33%]
  tests/functional/examples/test_notebooks_gpu.py F                        [ 66%]
  tests/smoke/recommenders/models/test_newsrec_model.py .                  [100%]
  
  =================================== FAILURES ===================================
  _______ test_benchmark_movielens_gpu[size0-algos0-expected_values_ndcg0] _______
  
  notebooks = {'als_deep_dive': '/mnt/azureml/cr/j/64eb05e922a445c3b9dfeebd9ea00029/exe/wd/examples/02_model_collaborative_filtering...rk_movielens': '/mnt/azureml/cr/j/64eb05e922a445c3b9dfeebd9ea00029/exe/wd/examples/06_benchmarks/movielens.ipynb', ...}
  output_notebook = 'output.ipynb', kernel_name = 'python3', size = ['100k']
  algos = ['ncf', 'fastai', 'bivae', 'lightgcn']
  expected_values_ndcg = [0.382793, 0.147583, 0.471722, 0.412664]
  
      @pytest.mark.gpu
      @pytest.mark.notebooks
      @pytest.mark.parametrize(
          "size, algos, expected_values_ndcg",
          [
              (
                  ["100k"],
                  ["ncf", "fastai", "bivae", "lightgcn"],
                  [0.382793, 0.147583, 0.471722, 0.412664],
              ),
          ],
      )
      def test_benchmark_movielens_gpu(
          notebooks, output_notebook, kernel_name, size, algos, expected_values_ndcg
      ):
          notebook_path = notebooks["benchmark_movielens"]
          execute_notebook(
              notebook_path,
              output_notebook,
              kernel_name=kernel_name,
              parameters=dict(data_sizes=size, algorithms=algos),
          )
          results = read_notebook(output_notebook)
      
          assert len(results) == 4
          for i, value in enumerate(algos):
  >           assert results[value] == pytest.approx(
                  expected_values_ndcg[i], rel=TOL, abs=ABS_TOL
              )
  E           assert 0.33010868928227394 == 0.382793 ± 5.0e-02
  E             
  E             comparison failed
  E             Obtained: 0.33010868928227394
  E             Expected: 0.382793 ± 5.0e-02

Link: https://github.com/recommenders-team/recommenders/actions/runs/12467800197/job/34804900031#step:3:2872

@miguelgfierro
Copy link
Collaborator Author

finally, they were all transitioning errors: https://github.com/recommenders-team/recommenders/actions/runs/12467800197

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants