Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Logs from the API should not be displayed by default in the odo dev output #6987

Closed
2 tasks
Tracked by #6895
rm3l opened this issue Jul 19, 2023 · 0 comments · Fixed by #7008
Closed
2 tasks
Tracked by #6895

Logs from the API should not be displayed by default in the odo dev output #6987

rm3l opened this issue Jul 19, 2023 · 0 comments · Fixed by #7008
Assignees
Labels
area/dev Issues or PRs related to `odo dev` kind/task Issue is actionable task
Milestone

Comments

@rm3l
Copy link
Member

rm3l commented Jul 19, 2023

/kind task

Currently, all incoming requests to the API Server are logged in the odo dev output. This pollutes the output of odo dev, and makes it hard to spot potentially useful messages (like events related to the dev pod, or even forwarded ports, ...).
They can still be useful; so we can show them only if running with some verbosity level.

2023/07/21 11:47:40 PUT /api/v1/devstate/devfile DevstateDevfilePut 2.944034ms
2023/07/21 11:48:35 PUT /api/v1/devstate/devfile DevstateDevfilePut 6.791118ms
2023/07/21 11:48:35 GET /api/v1/devstate/chart DevstateChartGet 87.23µs
↪ Dev mode
 Status:
 Watching for changes in the current directory /home/asoro/work/tmp/6902-propagate-changes-from-the-local-devfile-to-the-odo-dev-web-ui-and-vice-versa
2023/07/21 11:49:34 PUT /api/v1/devstate/devfile DevstateDevfilePut 3.407181ms
2023/07/21 11:49:34 GET /api/v1/devstate/chart DevstateChartGet 104.074µs
2023/07/21 11:49:34 PUT /api/v1/devfile DevfilePut 4.088482ms
 Keyboard Commands:
[Ctrl+c] - Exit and delete resources from the cluster
     [p] - Manually apply local changes to the application on the cluster
2023/07/21 11:50:08 GET /api/v1/notifications ServerSentEvents 5m50.733179598s
2023/07/21 11:50:08 GET /api/v1/devfile DevfileGet 97.595µs
2023/07/21 11:50:08 GET /api/v1/telemetry TelemetryGet 17.64µs
2023/07/21 11:50:08 PUT /api/v1/devstate/devfile DevstateDevfilePut 3.302015ms
2023/07/21 11:50:08 GET /api/v1/devstate/chart DevstateChartGet 91.301µs
2023/07/21 11:50:27 PUT /api/v1/devstate/devfile DevstateDevfilePut 4.496208ms
2023/07/21 11:50:27 GET /api/v1/devstate/chart DevstateChartGet 76.884µs
2023/07/21 11:50:48 GET /api/v1/notifications ServerSentEvents 5m48.250676917s
2023/07/21 11:51:19 PUT /api/v1/devstate/devfile DevstateDevfilePut 4.188223ms
2023/07/21 11:51:19 GET /api/v1/devstate/chart DevstateChartGet 80.038µs
2023/07/21 11:59:25 PUT /api/v1/devstate/devfile DevstateDevfilePut 3.403564ms
2023/07/21 11:59:25 GET /api/v1/devstate/chart DevstateChartGet 107.929µs

Acceptance Criteria

  • Hide them by default for odo dev and odo api-server
  • Show them when running in verbose mode (e.g., with -v 2)
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label Jul 19, 2023
@rm3l rm3l changed the title Logs from the API should not be displayed by default in the odo dev output (later) Logs from the API should not be displayed by default in the odo dev output Jul 19, 2023
@rm3l rm3l added kind/task Issue is actionable task and removed needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. labels Jul 19, 2023
@rm3l rm3l added the area/dev Issues or PRs related to `odo dev` label Jul 20, 2023
@feloy feloy self-assigned this Jul 25, 2023
@feloy feloy mentioned this issue Jul 31, 2023
3 tasks
@feloy feloy moved this to In Progress 🚧 in odo Project Jul 31, 2023
@feloy feloy moved this from In Progress 🚧 to In Review 👀 in odo Project Jul 31, 2023
@rm3l rm3l added this to the v3.14.0 🚀 milestone Aug 1, 2023
@github-project-automation github-project-automation bot moved this from In Review 👀 to Done ✅ in odo Project Aug 1, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area/dev Issues or PRs related to `odo dev` kind/task Issue is actionable task
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants