Skip to content

Commit 45071b9

Browse files
joshuawilsonjoshuawilson
committed
update test names to use a dash instead of capital
1 parent 436fbbb commit 45071b9

26 files changed

+314
-314
lines changed

‎test/eventingTree/broker.json

+6-6
Original file line numberDiff line numberDiff line change
@@ -49,10 +49,10 @@
4949
"time": "2020-11-16T19:54:50Z"
5050
}
5151
],
52-
"name": "exampleBroker0",
52+
"name": "example-broker0",
5353
"namespace": "josh",
5454
"resourceVersion": "48128",
55-
"selfLink": "/apis/eventing.knative.dev/v1beta1/namespaces/josh/brokers/exampleBroker0",
55+
"selfLink": "/apis/eventing.knative.dev/v1beta1/namespaces/josh/brokers/example-broker0",
5656
"uid": "5d4f1b9a-e091-4379-9de9-49f6c68d9b22"
5757
},
5858
"spec": {
@@ -65,7 +65,7 @@
6565
},
6666
"status": {
6767
"address": {
68-
"url": "http://broker-ingress.knative-eventing.svc.cluster.local/josh/exampleBroker0"
68+
"url": "http://broker-ingress.knative-eventing.svc.cluster.local/josh/example-broker0"
6969
},
7070
"conditions": [
7171
{
@@ -145,10 +145,10 @@
145145
"time": "2020-11-16T19:54:50Z"
146146
}
147147
],
148-
"name": "exampleBroker1",
148+
"name": "example-broker1",
149149
"namespace": "josh",
150150
"resourceVersion": "48114",
151-
"selfLink": "/apis/eventing.knative.dev/v1beta1/namespaces/josh/brokers/exampleBroker1",
151+
"selfLink": "/apis/eventing.knative.dev/v1beta1/namespaces/josh/brokers/example-broker1",
152152
"uid": "961f8b93-84b6-4b4c-944e-0e69da66f2e5"
153153
},
154154
"spec": {
@@ -161,7 +161,7 @@
161161
},
162162
"status": {
163163
"address": {
164-
"url": "http://broker-ingress.knative-eventing.svc.cluster.local/josh/exampleBroker1"
164+
"url": "http://broker-ingress.knative-eventing.svc.cluster.local/josh/example-broker1"
165165
},
166166
"conditions": [
167167
{

‎test/eventingTree/brokerDataProvider.test.ts

+6-6
Original file line numberDiff line numberDiff line change
@@ -23,21 +23,21 @@ suite('BrokerDataProvider', () => {
2323

2424
const eventingFolderNodes: EventingTreeItem[] = eventingDataProvider.getEventingFolders();
2525

26-
const testBroker0: Broker = new Broker('exampleBroker0', 'Brokers', JSON.parse(JSON.stringify(brokerData.items[0])));
26+
const testBroker0: Broker = new Broker('example-broker0', 'Brokers', JSON.parse(JSON.stringify(brokerData.items[0])));
2727
const testBroker0TreeItem: EventingTreeItem = new EventingTreeItem(
2828
eventingFolderNodes[0],
2929
testBroker0,
30-
'exampleBroker0',
30+
'example-broker0',
3131
EventingContextType.BROKER,
3232
vscode.TreeItemCollapsibleState.None,
3333
null,
3434
null,
3535
);
36-
const testBroker1: Broker = new Broker('exampleBroker1', 'Brokers', JSON.parse(JSON.stringify(brokerData.items[1])));
36+
const testBroker1: Broker = new Broker('example-broker1', 'Brokers', JSON.parse(JSON.stringify(brokerData.items[1])));
3737
const testBroker1TreeItem: EventingTreeItem = new EventingTreeItem(
3838
eventingFolderNodes[0],
3939
testBroker1,
40-
'exampleBroker1',
40+
'example-broker1',
4141
EventingContextType.BROKER,
4242
vscode.TreeItemCollapsibleState.None,
4343
null,
@@ -71,7 +71,7 @@ suite('BrokerDataProvider', () => {
7171
const result = await brokerDataProvider.getBrokers(eventingFolderNodes[0]);
7272
assert.equals(result[0], testBrokerTreeItems[0]);
7373
expect(result).to.have.lengthOf(2);
74-
expect(result[0].label).equals('exampleBroker0');
74+
expect(result[0].label).equals('example-broker0');
7575
});
7676
test('should refetch broker info when it is incomplete, then return broker nodes', async () => {
7777
sandbox.restore();
@@ -82,7 +82,7 @@ suite('BrokerDataProvider', () => {
8282
const result = await brokerDataProvider.getBrokers(eventingFolderNodes[0]);
8383
assert.equals(result[0], testBrokerTreeItems[0]);
8484
expect(result).to.have.lengthOf(2);
85-
expect(result[0].label).equals('exampleBroker0');
85+
expect(result[0].label).equals('example-broker0');
8686
});
8787
});
8888
});

‎test/eventingTree/brokerIncomplete.json

+6-6
Original file line numberDiff line numberDiff line change
@@ -49,10 +49,10 @@
4949
"time": "2020-11-16T19:54:50Z"
5050
}
5151
],
52-
"name": "exampleBroker0",
52+
"name": "example-broker0",
5353
"namespace": "josh",
5454
"resourceVersion": "48128",
55-
"selfLink": "/apis/eventing.knative.dev/v1beta1/namespaces/josh/brokers/exampleBroker0",
55+
"selfLink": "/apis/eventing.knative.dev/v1beta1/namespaces/josh/brokers/example-broker0",
5656
"uid": "5d4f1b9a-e091-4379-9de9-49f6c68d9b22"
5757
},
5858
"spec": {
@@ -65,7 +65,7 @@
6565
},
6666
"status": {
6767
"address": {
68-
"url": "http://broker-ingress.knative-eventing.svc.cluster.local/josh/exampleBroker0"
68+
"url": "http://broker-ingress.knative-eventing.svc.cluster.local/josh/example-broker0"
6969
},
7070
"observedGeneration": 1
7171
}
@@ -118,10 +118,10 @@
118118
"time": "2020-11-16T19:54:50Z"
119119
}
120120
],
121-
"name": "exampleBroker1",
121+
"name": "example-broker1",
122122
"namespace": "josh",
123123
"resourceVersion": "48114",
124-
"selfLink": "/apis/eventing.knative.dev/v1beta1/namespaces/josh/brokers/exampleBroker1",
124+
"selfLink": "/apis/eventing.knative.dev/v1beta1/namespaces/josh/brokers/example-broker1",
125125
"uid": "961f8b93-84b6-4b4c-944e-0e69da66f2e5"
126126
},
127127
"spec": {
@@ -134,7 +134,7 @@
134134
},
135135
"status": {
136136
"address": {
137-
"url": "http://broker-ingress.knative-eventing.svc.cluster.local/josh/exampleBroker1"
137+
"url": "http://broker-ingress.knative-eventing.svc.cluster.local/josh/example-broker1"
138138
},
139139
"observedGeneration": 1
140140
}

‎test/eventingTree/channel.json

+8-8
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,10 @@
4444
"time": "2020-11-16T19:54:52Z"
4545
}
4646
],
47-
"name": "exampleChannel0",
47+
"name": "example-channel0",
4848
"namespace": "josh",
4949
"resourceVersion": "48328",
50-
"selfLink": "/apis/messaging.knative.dev/v1beta1/namespaces/josh/channels/exampleChannel0",
50+
"selfLink": "/apis/messaging.knative.dev/v1beta1/namespaces/josh/channels/example-channel0",
5151
"uid": "51800e5d-5e0a-41b5-a3ef-0cf5f60c491b"
5252
},
5353
"spec": {
@@ -58,12 +58,12 @@
5858
},
5959
"status": {
6060
"address": {
61-
"url": "http://exampleChannel0-kn-channel.josh.svc.cluster.local"
61+
"url": "http://example-channel0-kn-channel.josh.svc.cluster.local"
6262
},
6363
"channel": {
6464
"apiVersion": "messaging.knative.dev/v1beta1",
6565
"kind": "InMemoryChannel",
66-
"name": "exampleChannel0",
66+
"name": "example-channel0",
6767
"namespace": "josh"
6868
},
6969
"conditions": [
@@ -136,10 +136,10 @@
136136
"time": "2020-11-16T20:09:40Z"
137137
}
138138
],
139-
"name": "exampleChannel1",
139+
"name": "example-channel1",
140140
"namespace": "josh",
141141
"resourceVersion": "57792",
142-
"selfLink": "/apis/messaging.knative.dev/v1beta1/namespaces/josh/channels/exampleChannel1",
142+
"selfLink": "/apis/messaging.knative.dev/v1beta1/namespaces/josh/channels/example-channel1",
143143
"uid": "52d3fe8d-9c64-4171-b02a-d068e3607b03"
144144
},
145145
"spec": {
@@ -150,12 +150,12 @@
150150
},
151151
"status": {
152152
"address": {
153-
"url": "http://exampleChannel1-kn-channel.josh.svc.cluster.local"
153+
"url": "http://example-channel1-kn-channel.josh.svc.cluster.local"
154154
},
155155
"channel": {
156156
"apiVersion": "messaging.knative.dev/v1beta1",
157157
"kind": "InMemoryChannel",
158-
"name": "exampleChannel1",
158+
"name": "example-channel1",
159159
"namespace": "josh"
160160
},
161161
"conditions": [

‎test/eventingTree/channelDataProvider.test.ts

+6-6
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ suite('ChannelDataProvider', () => {
2424
const eventingFolderNodes: EventingTreeItem[] = eventingDataProvider.getEventingFolders();
2525

2626
const testChannel0: Channel = new Channel(
27-
'exampleChannel0',
27+
'example-channel0',
2828
'Channels',
2929
'InMemoryChannel',
3030
JSON.parse(JSON.stringify(channelData.items[0])),
@@ -33,14 +33,14 @@ suite('ChannelDataProvider', () => {
3333
const testChannel0TreeItem: EventingTreeItem = new EventingTreeItem(
3434
eventingFolderNodes[1],
3535
testChannel0,
36-
'exampleChannel0',
36+
'example-channel0',
3737
EventingContextType.CHANNEL,
3838
vscode.TreeItemCollapsibleState.None,
3939
null,
4040
null,
4141
);
4242
const testChannel1: Channel = new Channel(
43-
'exampleChannel1',
43+
'example-channel1',
4444
'Channels',
4545
'InMemoryChannel',
4646
JSON.parse(JSON.stringify(channelData.items[1])),
@@ -49,7 +49,7 @@ suite('ChannelDataProvider', () => {
4949
const testChannel1TreeItem: EventingTreeItem = new EventingTreeItem(
5050
eventingFolderNodes[1],
5151
testChannel1,
52-
'exampleChannel1',
52+
'example-channel1',
5353
EventingContextType.CHANNEL,
5454
vscode.TreeItemCollapsibleState.None,
5555
null,
@@ -83,7 +83,7 @@ suite('ChannelDataProvider', () => {
8383
const result = await channelDataProvider.getChannels(eventingFolderNodes[1]);
8484
assert.equals(result[0], testChannelTreeItems[0]);
8585
expect(result).to.have.lengthOf(4);
86-
expect(result[0].label).equals('exampleChannel0');
86+
expect(result[0].label).equals('example-channel0');
8787
});
8888
test('should refetch channel info when it is incomplete, then return channel nodes', async () => {
8989
sandbox.restore();
@@ -94,7 +94,7 @@ suite('ChannelDataProvider', () => {
9494
const result = await channelDataProvider.getChannels(eventingFolderNodes[1]);
9595
assert.equals(result[0], testChannelTreeItems[0]);
9696
expect(result).to.have.lengthOf(4);
97-
expect(result[0].label).equals('exampleChannel0');
97+
expect(result[0].label).equals('example-channel0');
9898
});
9999
});
100100
});

‎test/eventingTree/channelIncomplete.json

+8-8
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,10 @@
4444
"time": "2020-11-16T19:54:52Z"
4545
}
4646
],
47-
"name": "exampleChannel0",
47+
"name": "example-channel0",
4848
"namespace": "josh",
4949
"resourceVersion": "48328",
50-
"selfLink": "/apis/messaging.knative.dev/v1beta1/namespaces/josh/channels/exampleChannel0",
50+
"selfLink": "/apis/messaging.knative.dev/v1beta1/namespaces/josh/channels/example-channel0",
5151
"uid": "51800e5d-5e0a-41b5-a3ef-0cf5f60c491b"
5252
},
5353
"spec": {
@@ -58,12 +58,12 @@
5858
},
5959
"status": {
6060
"address": {
61-
"url": "http://exampleChannel0-kn-channel.josh.svc.cluster.local"
61+
"url": "http://example-channel0-kn-channel.josh.svc.cluster.local"
6262
},
6363
"channel": {
6464
"apiVersion": "messaging.knative.dev/v1beta1",
6565
"kind": "InMemoryChannel",
66-
"name": "exampleChannel0",
66+
"name": "example-channel0",
6767
"namespace": "josh"
6868
},
6969
"observedGeneration": 1,
@@ -119,10 +119,10 @@
119119
"time": "2020-11-16T20:09:40Z"
120120
}
121121
],
122-
"name": "exampleChannel1",
122+
"name": "example-channel1",
123123
"namespace": "josh",
124124
"resourceVersion": "57792",
125-
"selfLink": "/apis/messaging.knative.dev/v1beta1/namespaces/josh/channels/exampleChannel1",
125+
"selfLink": "/apis/messaging.knative.dev/v1beta1/namespaces/josh/channels/example-channel1",
126126
"uid": "52d3fe8d-9c64-4171-b02a-d068e3607b03"
127127
},
128128
"spec": {
@@ -133,12 +133,12 @@
133133
},
134134
"status": {
135135
"address": {
136-
"url": "http://exampleChannel1-kn-channel.josh.svc.cluster.local"
136+
"url": "http://example-channel1-kn-channel.josh.svc.cluster.local"
137137
},
138138
"channel": {
139139
"apiVersion": "messaging.knative.dev/v1beta1",
140140
"kind": "InMemoryChannel",
141-
"name": "exampleChannel1",
141+
"name": "example-channel1",
142142
"namespace": "josh"
143143
},
144144
"observedGeneration": 1,

‎test/eventingTree/channelList.yaml

+8-8
Original file line numberDiff line numberDiff line change
@@ -32,22 +32,22 @@ items:
3232
manager: controller
3333
operation: Update
3434
time: '2020-11-17T15:32:49Z'
35-
name: exampleChannel0
35+
name: example-channel0
3636
namespace: josh
3737
resourceVersion: '60273'
38-
selfLink: /apis/messaging.knative.dev/v1beta1/namespaces/josh/channels/exampleChannel0
38+
selfLink: /apis/messaging.knative.dev/v1beta1/namespaces/josh/channels/example-channel0
3939
uid: 318433b2-cd12-4deb-8353-cdde1549f88f
4040
spec:
4141
channelTemplate:
4242
apiVersion: messaging.knative.dev/v1beta1
4343
kind: InMemoryChannel
4444
status:
4545
address:
46-
url: http://exampleChannel0-kn-channel.josh.svc.cluster.local
46+
url: http://example-channel0-kn-channel.josh.svc.cluster.local
4747
channel:
4848
apiVersion: messaging.knative.dev/v1beta1
4949
kind: InMemoryChannel
50-
name: exampleChannel0
50+
name: example-channel0
5151
namespace: josh
5252
conditions:
5353
- lastTransitionTime: '2020-11-17T15:32:46Z'
@@ -96,22 +96,22 @@ items:
9696
manager: controller
9797
operation: Update
9898
time: '2020-11-17T15:32:50Z'
99-
name: exampleChannel1
99+
name: example-channel1
100100
namespace: josh
101101
resourceVersion: '60310'
102-
selfLink: /apis/messaging.knative.dev/v1beta1/namespaces/josh/channels/exampleChannel1
102+
selfLink: /apis/messaging.knative.dev/v1beta1/namespaces/josh/channels/example-channel1
103103
uid: 0b2f7df2-6f65-42de-a8e6-73d13dd2b37d
104104
spec:
105105
channelTemplate:
106106
apiVersion: messaging.knative.dev/v1beta1
107107
kind: InMemoryChannel
108108
status:
109109
address:
110-
url: http://exampleChannel1-kn-channel.josh.svc.cluster.local
110+
url: http://example-channel1-kn-channel.josh.svc.cluster.local
111111
channel:
112112
apiVersion: messaging.knative.dev/v1beta1
113113
kind: InMemoryChannel
114-
name: exampleChannel1
114+
name: example-channel1
115115
namespace: josh
116116
conditions:
117117
- lastTransitionTime: '2020-11-17T15:32:46Z'

0 commit comments

Comments
 (0)