From 8c6432e397afc6b2c306dbf83b92c8f04f780019 Mon Sep 17 00:00:00 2001 From: mohamed amine ozennou <102986762+ozennou@users.noreply.github.com> Date: Fri, 17 Jan 2025 11:14:19 +0100 Subject: [PATCH 01/10] Add Go 1.22.x and 1.23.x, drop unsupported Go 1.19.x --- .github/workflows/build.yml | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 7578e962e..bffd14010 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -16,7 +16,7 @@ jobs: strategy: fail-fast: false matrix: - go-version: [1.19.x, 1.20.x, 1.21.x] + go-version: [1.20.x, 1.21.x, 1.22.x, 1.23.x] services: redis: @@ -56,10 +56,11 @@ jobs: - "7.2.6" - "6.2.16" go-version: - - "1.19.x" - "1.20.x" - "1.21.x" - + - "1.22.x" + - "1.23.x" + steps: - name: Set up ${{ matrix.go-version }} uses: actions/setup-go@v5 @@ -73,7 +74,7 @@ jobs: - name: Set up Docker Compose environment run: | docker compose --profile all up -d - + - name: Run tests env: USE_CONTAINERIZED_REDIS: "true" From de0e8144c6f35fb7a57d0be149a4300921b5d5d2 Mon Sep 17 00:00:00 2001 From: mohamed amine ozennou <102986762+ozennou@users.noreply.github.com> Date: Fri, 17 Jan 2025 11:52:53 +0100 Subject: [PATCH 02/10] Caching dependency files --- .github/workflows/build.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index bffd14010..994939ddb 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -31,6 +31,7 @@ jobs: uses: actions/setup-go@v5 with: go-version: ${{ matrix.go-version }} + cache-dependency-path: "**/*.sum" - name: Checkout code uses: actions/checkout@v4 @@ -43,6 +44,9 @@ jobs: with: files: coverage.txt token: ${{ secrets.CODECOV_TOKEN }} + + - name: check the *.sum files location + run: ls -la **/*.sum test-redis-ce: name: test-redis-ce @@ -66,6 +70,7 @@ jobs: uses: actions/setup-go@v5 with: go-version: ${{ matrix.go-version }} + cache-dependency-path: "**/*.sum" - name: Checkout code uses: actions/checkout@v4 From e4a1d91b5d2f20cb087c23e5f51c4a793cb3235b Mon Sep 17 00:00:00 2001 From: mohamed amine ozennou <102986762+ozennou@users.noreply.github.com> Date: Fri, 17 Jan 2025 12:23:10 +0100 Subject: [PATCH 03/10] Update build.yml --- .github/workflows/build.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 994939ddb..2a0804f71 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -44,9 +44,6 @@ jobs: with: files: coverage.txt token: ${{ secrets.CODECOV_TOKEN }} - - - name: check the *.sum files location - run: ls -la **/*.sum test-redis-ce: name: test-redis-ce From 6f9a821ebee81b5b20523cb854d682e26a0880dc Mon Sep 17 00:00:00 2001 From: mohamed amine ozennou <102986762+ozennou@users.noreply.github.com> Date: Fri, 17 Jan 2025 12:32:51 +0100 Subject: [PATCH 04/10] Update build.yml --- .github/workflows/build.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 2a0804f71..bffd14010 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -31,7 +31,6 @@ jobs: uses: actions/setup-go@v5 with: go-version: ${{ matrix.go-version }} - cache-dependency-path: "**/*.sum" - name: Checkout code uses: actions/checkout@v4 @@ -67,7 +66,6 @@ jobs: uses: actions/setup-go@v5 with: go-version: ${{ matrix.go-version }} - cache-dependency-path: "**/*.sum" - name: Checkout code uses: actions/checkout@v4 From 1c4669c63af02d42f1e57eae69f577e99d016e3c Mon Sep 17 00:00:00 2001 From: mohamed amine ozennou <102986762+ozennou@users.noreply.github.com> Date: Fri, 17 Jan 2025 12:33:53 +0100 Subject: [PATCH 05/10] Update doctests.yaml --- .github/workflows/doctests.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/doctests.yaml b/.github/workflows/doctests.yaml index 6e49e6477..1ae93fe76 100644 --- a/.github/workflows/doctests.yaml +++ b/.github/workflows/doctests.yaml @@ -25,7 +25,7 @@ jobs: strategy: fail-fast: false matrix: - go-version: [ "1.18", "1.19", "1.20", "1.21" ] + go-version: [ "1.20", "1.21", "1.22", "1.23" ] steps: - name: Set up ${{ matrix.go-version }} From 6707b9b63a77c445a55af349e879cfab83d4a15e Mon Sep 17 00:00:00 2001 From: mohamed amine ozennou <102986762+ozennou@users.noreply.github.com> Date: Fri, 17 Jan 2025 12:35:43 +0100 Subject: [PATCH 06/10] Update test-redis-enterprise.yml --- .github/workflows/test-redis-enterprise.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test-redis-enterprise.yml b/.github/workflows/test-redis-enterprise.yml index 1cb36b8d2..0593c7dfb 100644 --- a/.github/workflows/test-redis-enterprise.yml +++ b/.github/workflows/test-redis-enterprise.yml @@ -15,7 +15,7 @@ jobs: strategy: fail-fast: false matrix: - go-version: [1.21.x] + go-version: ["1.21.x", "1.22.x", "1.23.x"] re-build: ["7.4.2-54"] steps: From 56520d1c148d153bccb9fa819cfd75bd32576d5d Mon Sep 17 00:00:00 2001 From: mohamed amine ozennou <102986762+ozennou@users.noreply.github.com> Date: Fri, 17 Jan 2025 12:47:46 +0100 Subject: [PATCH 07/10] Update test-redis-enterprise.yml --- .github/workflows/test-redis-enterprise.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test-redis-enterprise.yml b/.github/workflows/test-redis-enterprise.yml index 0593c7dfb..113478b8b 100644 --- a/.github/workflows/test-redis-enterprise.yml +++ b/.github/workflows/test-redis-enterprise.yml @@ -15,7 +15,7 @@ jobs: strategy: fail-fast: false matrix: - go-version: ["1.21.x", "1.22.x", "1.23.x"] + go-version: ["1.21.x"] re-build: ["7.4.2-54"] steps: From c6b0cc83ca8857a2b0aafdfc6aa6fd1fa68a5608 Mon Sep 17 00:00:00 2001 From: mohamed amine ozennou <102986762+ozennou@users.noreply.github.com> Date: Fri, 17 Jan 2025 18:32:59 +0100 Subject: [PATCH 08/10] Update Go version in go.mod from 1.18 to 1.20 --- go.mod | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/go.mod b/go.mod index c1d9037ac..96b5f5dd6 100644 --- a/go.mod +++ b/go.mod @@ -1,6 +1,6 @@ module github.com/redis/go-redis/v9 -go 1.18 +go 1.20 require ( github.com/bsm/ginkgo/v2 v2.12.0 From b49e06cdc363ba5ca3eccde629b02a271689fb77 Mon Sep 17 00:00:00 2001 From: ozennou Date: Sun, 19 Jan 2025 15:26:28 +0100 Subject: [PATCH 09/10] revert go 1.19 in workflow --- .github/workflows/build.yml | 3 ++- .github/workflows/doctests.yaml | 2 +- go.mod | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index bffd14010..21484bacc 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -16,7 +16,7 @@ jobs: strategy: fail-fast: false matrix: - go-version: [1.20.x, 1.21.x, 1.22.x, 1.23.x] + go-version: [1.19.x, 1.20.x, 1.21.x, 1.22.x, 1.23.x] services: redis: @@ -56,6 +56,7 @@ jobs: - "7.2.6" - "6.2.16" go-version: + - "1.19.x" - "1.20.x" - "1.21.x" - "1.22.x" diff --git a/.github/workflows/doctests.yaml b/.github/workflows/doctests.yaml index 1ae93fe76..bd006be28 100644 --- a/.github/workflows/doctests.yaml +++ b/.github/workflows/doctests.yaml @@ -25,7 +25,7 @@ jobs: strategy: fail-fast: false matrix: - go-version: [ "1.20", "1.21", "1.22", "1.23" ] + go-version: [ "1.18", "1.19", "1.20", "1.21", "1.22", "1.23" ] steps: - name: Set up ${{ matrix.go-version }} diff --git a/go.mod b/go.mod index 96b5f5dd6..c1d9037ac 100644 --- a/go.mod +++ b/go.mod @@ -1,6 +1,6 @@ module github.com/redis/go-redis/v9 -go 1.20 +go 1.18 require ( github.com/bsm/ginkgo/v2 v2.12.0 From ac994e7dc11fce0f35a34a70a41abf56b21a5250 Mon Sep 17 00:00:00 2001 From: ozennou Date: Sun, 19 Jan 2025 20:40:01 +0100 Subject: [PATCH 10/10] drop Go 1.19, 1.20, 1.21 --- .github/workflows/build.yml | 5 +---- .github/workflows/doctests.yaml | 2 +- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 21484bacc..e91f5ac41 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -16,7 +16,7 @@ jobs: strategy: fail-fast: false matrix: - go-version: [1.19.x, 1.20.x, 1.21.x, 1.22.x, 1.23.x] + go-version: [1.22.x, 1.23.x] services: redis: @@ -56,9 +56,6 @@ jobs: - "7.2.6" - "6.2.16" go-version: - - "1.19.x" - - "1.20.x" - - "1.21.x" - "1.22.x" - "1.23.x" diff --git a/.github/workflows/doctests.yaml b/.github/workflows/doctests.yaml index bd006be28..59588be07 100644 --- a/.github/workflows/doctests.yaml +++ b/.github/workflows/doctests.yaml @@ -25,7 +25,7 @@ jobs: strategy: fail-fast: false matrix: - go-version: [ "1.18", "1.19", "1.20", "1.21", "1.22", "1.23" ] + go-version: [ "1.22", "1.23" ] steps: - name: Set up ${{ matrix.go-version }}