Skip to content

Commit 4bbc122

Browse files
dvora-hvladvildanov
authored andcommitted
Fix: hset unexpectedly mutates the list passed to items (#3103)
1 parent 1bf1705 commit 4bbc122

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

Diff for: redis/commands/core.py

+6-4
Original file line numberDiff line numberDiff line change
@@ -5017,14 +5017,16 @@ def hset(
50175017
"""
50185018
if key is None and not mapping and not items:
50195019
raise DataError("'hset' with no key value pairs")
5020-
items = items or []
5020+
pieces = []
5021+
if items:
5022+
pieces.extend(items)
50215023
if key is not None:
5022-
items.extend((key, value))
5024+
pieces.extend((key, value))
50235025
if mapping:
50245026
for pair in mapping.items():
5025-
items.extend(pair)
5027+
pieces.extend(pair)
50265028

5027-
return self.execute_command("HSET", name, *items)
5029+
return self.execute_command("HSET", name, *pieces)
50285030

50295031
def hsetnx(self, name: str, key: str, value: str) -> Union[Awaitable[bool], bool]:
50305032
"""

0 commit comments

Comments
 (0)