Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Failing test with query timeout in test_graph.py #2591

Closed
Ernest0x opened this issue Feb 14, 2023 · 1 comment
Closed

Failing test with query timeout in test_graph.py #2591

Ernest0x opened this issue Feb 14, 2023 · 1 comment
Assignees
Labels
maintenance Maintenance (CI, Releases, etc)

Comments

@Ernest0x
Copy link

Version: Current master

Platform: Whatever platform the CI tests run on

Description: After merging upstream changes to my branch for #2470 I realized that there was one CI test failing (https://github.com/redis/redis-py/actions/runs/4174611486/jobs/7228412511) which seemed irrelevant with the (small) changes I introduce in that PR. Then I took a look at previous CI runs and I found out that the same test had failed for another, irrelevant branch too. My guess is that the failing test at

client.graph().query("MATCH (a), (b), (c), (d) RETURN *", timeout=1)
assumes that the query will be taking long enough time to cause a ResponseError when a 1-millisecond timeout argument is passed in the query call. So, it could be that the query has become fast enough lately so that the timeout is not reached.

@dvora-h dvora-h added the maintenance Maintenance (CI, Releases, etc) label Mar 16, 2023
@dvora-h
Copy link
Collaborator

dvora-h commented Jul 16, 2023

Test marked as flaky in #2809

@dvora-h dvora-h closed this as completed Jul 16, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

No branches or pull requests

3 participants