Skip to content

Wrong type annotation on the method return type for from_url #3143

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
Leggendario12 opened this issue Feb 13, 2024 · 4 comments
Closed

Wrong type annotation on the method return type for from_url #3143

Leggendario12 opened this issue Feb 13, 2024 · 4 comments

Comments

@Leggendario12
Copy link

There is an error in the type annotation in the Redis client.py file of the Redis class. The from_url method has a type annotation of None for its return, but it is clearly returning an instance of the Redis client.

Version: "^5.2.0"

Platform: Ubuntu 22.04

Description: Linter warning error of return None.

@dvora-h
Copy link
Collaborator

dvora-h commented Feb 19, 2024

Hi @Leggendario12 thanks for reporting this, it was fixed already in #2963

@dvora-h dvora-h closed this as completed Feb 19, 2024
@andy2mrqz
Copy link

@dvora-h There has not been a release for this project tagged since September, 2023 - is there a plan to release a version with this fix incoporated?

@wkeil1
Copy link

wkeil1 commented Feb 25, 2024

I'm running into the same issue and am also wondering when the release will come out with the fix.

@dvora-h
Copy link
Collaborator

dvora-h commented Mar 14, 2024

5.0.3 released this week

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants