-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
[REQ] Babel update #206
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
I'm running into this as well in a react-native 0.16 project which uses Babel 6 under the hood. Looks like the .babelrc in react-redux throws an |
I'm unable to build with the changes made to
|
As a workaround for the |
Interesting, @NullDivision -- so you basically kill the local installations and rely on the global? In theory, it sounds like this might also let you compile |
I'm not sure about the I need |
Just an idea for another workaround - would using a precompiled version of react-redux would work? I see there is a precompiled version on the CDN, but this is not for the native version. |
It's always a posibility but then what's the use of NPM and versioning? It also won't allow you to import it using ES6 unless you download the js file. |
Not without a terminal dump. |
All the tests are passing now. The PR is ready for review. |
I'm waiting for the PR to get merged so I can upgrade to 0.16 – I wonder is the PR intended for react-redux@3.1 right? AFAIK we can't use react-redux@4 with the current react-native version |
When will this PR be merged? |
Hey folks! I'm a bit confused why everyone is waiting for us updating to Babel 6. The library is compiled to ES5 :-). You shouldn't care what it uses internally. The real fix was to stop shipping |
The reason is that it breaks react-native apps builds. Can we also remove .babelrc from redux itself? It's also breaking for me on babel dependency. Here's where it's failing for react-native apps (0.16):
|
I don't know if it would work but could someone try moving the babelrc content into the package.json under "babel"? I think that might solve the issue. |
The Babel version we use internally doesn't matter. What mattered is that we shouldn't have shipped And it is also already removed from Redux. Please update to the latest version. @NullDivision As far as I know there is no issue to solve. What do you mean? It's already solved in the latest update to both packages. |
I still see |
We don't need to remove it from the source. (We still need Babel right :-). We removed it from NPM distribution by using "files" whitelist in package.json. |
Would it be possible to update Babel to version 6? Version 5 interferes with newly created projects.
The text was updated successfully, but these errors were encountered: