Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Ctrl+H doesn't hide DevTools container #54

Closed
shanewilson opened this issue Aug 12, 2015 · 6 comments
Closed

Ctrl+H doesn't hide DevTools container #54

shanewilson opened this issue Aug 12, 2015 · 6 comments

Comments

@shanewilson
Copy link

Hitting Ctrl+H hides the LogMonitor but not the DebugPanel - so you still see the box shadow and cannot click through.

https://github.com/gaearon/redux-devtools/blob/master/src/react/DebugPanel.js#L12
https://github.com/gaearon/redux-devtools/blob/master/src/react/LogMonitor.js#L115

Before Ctrl+H

<div style="position:fixed;z-index:10000;font-size:17px;overflow:hidden;opacity:1;color:white;right:0;top:0;bottom:0;max-height:100%;max-width:20%;min-width:300px;word-wrap:break-word;box-sizing:border-box;box-shadow:-2px 0 7px 0 rgba(0, 0, 0, 0.5);" data-reactid=".0.1">
<div ...>...stuff here...</div>
</div>

After Ctrl+H

<div style="position:fixed;z-index:10000;font-size:17px;overflow:hidden;opacity:1;color:white;right:0;top:0;bottom:0;max-height:100%;max-width:20%;min-width:300px;word-wrap:break-word;box-sizing:border-box;box-shadow:-2px 0 7px 0 rgba(0, 0, 0, 0.5);" data-reactid=".0.1">
<noscript data-reactid=".0.1.0"></noscript>
</div>

Fix

Removing min-width seems to fix it

@nicinabox nicinabox mentioned this issue Aug 12, 2015
8 tasks
@nicinabox
Copy link
Collaborator

@gaearon what about just toggling the DebugPanel directly?

@gaearon
Copy link
Contributor

gaearon commented Aug 12, 2015

@nicinabox

It's currently a dumb component, it doesn't even know whether to show itself. I'd rather keep it this way.

@nicinabox
Copy link
Collaborator

Moving min-width to LogMonitor seems like a good solution then. Not sure about keeping max-width though as it seems to interfere with button visibility. Do you think the width will end up being configurable/draggable?

@shanewilson
Copy link
Author

moving the min-width onto LogMonitor seemed like an easy fix - although I'm not sure why it needs a min width anyway.

@nicinabox
Copy link
Collaborator

It needs either width or min-width because the parent is position: fixed; else it collapses to the size of the largest child.

@gaearon
Copy link
Contributor

gaearon commented Aug 12, 2015

Should be fixed in 1.0.2

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants