Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix links to some headings with special chars #3494

Merged

Conversation

douglasnaphas
Copy link
Contributor

A couple of links in tables of contents were broken.

These were links where the URL fragment in the target was
auto-generated. When that happens, most special characters are removed
from the heading.

When the links in the tables of contents were written, the ones I am
fixing replaced some of the special characters with -, instead of
stripping them.

I tested the links on my fork on the Performance and React Redux pages.

These screenshots show that the currently live auto-generated URLs
match what I am changing the links to:

Screen Shot 2019-08-01 at 8 58 09 PM

Screen Shot 2019-08-01 at 8 59 46 PM

A couple of links in tables of contents were broken.

These were links where the URL fragment in the target was
auto-generated. When that happens, most special characters are removed
from the heading.

When the links in the tables of contents were written, the ones I am
fixing replaced some of the special characters with `-`, instead of
stripping them.
@netlify
Copy link

netlify bot commented Aug 2, 2019

Deploy preview for redux-docs ready!

Built with commit 0679292

https://deploy-preview-3494--redux-docs.netlify.com

@markerikson markerikson merged commit 7d3c083 into reduxjs:master Aug 2, 2019
@markerikson
Copy link
Contributor

Thanks!

@douglasnaphas douglasnaphas deleted the broken-links-quotes-in-headings branch August 2, 2019 16:41
webMasterMrBin pushed a commit to webMasterMrBin/redux that referenced this pull request Aug 21, 2021
A couple of links in tables of contents were broken.

These were links where the URL fragment in the target was
auto-generated. When that happens, most special characters are removed
from the heading.

When the links in the tables of contents were written, the ones I am
fixing replaced some of the special characters with `-`, instead of
stripping them.

Former-commit-id: 04c2939
Former-commit-id: 10f33a2
webMasterMrBin pushed a commit to webMasterMrBin/redux that referenced this pull request Aug 21, 2021
A couple of links in tables of contents were broken.

These were links where the URL fragment in the target was
auto-generated. When that happens, most special characters are removed
from the heading.

When the links in the tables of contents were written, the ones I am
fixing replaced some of the special characters with `-`, instead of
stripping them.

Former-commit-id: 04c2939
Former-commit-id: 10f33a2
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants