Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Upgrade ESLint from v7 to v8 #3623

Closed
thedavidprice opened this issue Oct 22, 2021 · 4 comments · Fixed by #3725
Closed

Upgrade ESLint from v7 to v8 #3623

thedavidprice opened this issue Oct 22, 2021 · 4 comments · Fixed by #3725
Assignees
Labels
hacktoberfest help wanted topic/config Babel, Webpack, ESLint, Prettier, etc.

Comments

@thedavidprice
Copy link
Contributor

thedavidprice commented Oct 22, 2021

Ideally this will be upgraded for v1-rc.

ESLint Release Notes:

After naive upgrade, I hit the following error:

$ yarn lint

Oops! Something went wrong! :(

ESLint: 7.32.0

ESLint couldn't find the plugin "eslint-plugin-react".

(The package "eslint-plugin-react" was not found when loaded as a Node module from the directory "/Users/price/Repos/redwoodjs-redwood".)

Ideally this will be upgraded for v1-rc.

@thedavidprice thedavidprice moved this to New issues in Triage Oct 22, 2021
@thedavidprice thedavidprice added this to the next-release-priority milestone Oct 22, 2021
@nzdjb
Copy link
Contributor

nzdjb commented Oct 23, 2021

Howdy,

I gave this a shot, but found after getting set up that there's no current release of eslint-plugin-react that is compatible with eslint 8: jsx-eslint/eslint-plugin-react#3055

They have a PR to resolve that: jsx-eslint/eslint-plugin-react#3059

Looks like there are other plugins that will need updating too, but I haven't found the status of those yet. Will look into them later on.

@thedavidprice
Copy link
Contributor Author

@nzdjb great info! If you want to watch that PR and help with the upgrade once a new version of eslint-plugin-react is published, that would be welcome. No pressure and not urgent.

@nzdjb
Copy link
Contributor

nzdjb commented Oct 23, 2021

Sure. I'll try to nail down the other blocking dependencies and list them here.

@nzdjb
Copy link
Contributor

nzdjb commented Oct 23, 2021

These are the PRs that need to be merged and released prior to upgrading to Eslint 8

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
hacktoberfest help wanted topic/config Babel, Webpack, ESLint, Prettier, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants