Skip to content

Commit 4cfbcb0

Browse files
cjihrigrefack
authored andcommitted
coverage: pass cwd to path.resolve() in setup
During coverage setup, path.resolve() is called. path.resolve() can potentially call process.cwd(), which hasn't been bootstrapped yet. This commit passes the current working directory directly so that path.resolve() doesn't attempt to compute it. PR-URL: nodejs#25289 Fixes: nodejs#25287 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent e812e0d commit 4cfbcb0

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

lib/internal/process/coverage.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -76,9 +76,10 @@ function setup() {
7676
}));
7777

7878
try {
79+
const { cwd } = internalBinding('process_methods');
7980
const { resolve } = require('path');
8081
coverageDirectory = process.env.NODE_V8_COVERAGE =
81-
resolve(process.env.NODE_V8_COVERAGE);
82+
resolve(cwd(), process.env.NODE_V8_COVERAGE);
8283
} catch (err) {
8384
process._rawDebug(err.toString());
8485
}

0 commit comments

Comments
 (0)