Skip to content

[BUG] The base app doesn't work with React 18, missing children prop. #1725

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
pabloalcaraz opened this issue Apr 17, 2022 · 3 comments · Fixed by #1718
Closed

[BUG] The base app doesn't work with React 18, missing children prop. #1725

pabloalcaraz opened this issue Apr 17, 2022 · 3 comments · Fixed by #1718
Labels
bug Something isn't working

Comments

@pabloalcaraz
Copy link

Describe the bug
The app doesn't work with React 18, the propertie "children" is mising in types of refine-antd and refine-core components that use.

To Reproduce
Update to react 18 on package.json and start the app.

Screenshots
image

@pabloalcaraz pabloalcaraz added the bug Something isn't working label Apr 17, 2022
@omeraplak
Copy link
Contributor

Hey @pabloalcaraz 👋,
Many of our dependencies haven't released React@18 support as latest yet. These are ant-design, react-testing-library and react-query. We are tracking all our dependencies and will upgrade to React@18 as soon as possible.

Possible workarounds are listed here,
facebook/react#24304

Refine React@18 PR: #1718

@rhuanbarros
Copy link

I created a new project today and this setup worked with the package.json

{ "name": "refine1l", "version": "0.1.0", "private": true, "dependencies": { "@pankod/refine-antd": "^3.22.1", "@pankod/refine-core": "^3.22.1", "@pankod/refine-react-router-v6": "^3.22.1", "@pankod/refine-simple-rest": "^3.22.1", "@testing-library/jest-dom": "^5.16.4", "@testing-library/react": "^12.1.1", "@testing-library/user-event": "^12.5.0", "@types/jest": "^27.5.1", "@types/node": "^16.11.36", "@types/react": "^17.0.2", "@types/react-dom": "^17.0.2", "react": "^17.0.2", "react-dom": "^17.0.2", "react-scripts": "5.0.1", "typescript": "^4.7.2", "web-vitals": "^2.1.4" }, "scripts": { "start": "react-scripts start", "build": "react-scripts build", "test": "react-scripts test", "eject": "react-scripts eject" }, "eslintConfig": { "extends": [ "react-app", "react-app/jest" ] }, "browserslist": { "production": [ ">0.2%", "not dead", "not op_mini all" ], "development": [ "last 1 chrome version", "last 1 firefox version", "last 1 safari version" ] } }

@omeraplak
Copy link
Contributor

Hey @pabloalcaraz ,
We've released react@18 support! 💥

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants