Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Joins with 1 listenable #132

Open
rektide opened this issue Nov 20, 2014 · 4 comments
Open

Joins with 1 listenable #132

rektide opened this issue Nov 20, 2014 · 4 comments

Comments

@rektide
Copy link

rektide commented Nov 20, 2014

It's becoming a bit painful to check whether we need to Reflux.join{Leading,Trailing,Concat,Strict} or use the non-static store.listen() in some of our tests. It would be pleasant if the join static methods worked whether there are multiple things or just one listenable to synchronize to.

@spoike
Copy link
Member

spoike commented Nov 26, 2014

It's kind of unnecessary to use joins if you already know you only have one listenable to listen to.

I do understand though that joins should support 1 listenable in case the join is made in a dynamic fashion.

@spoike spoike added this to the 0.2.13 milestone Aug 11, 2015
@spoike
Copy link
Member

spoike commented Aug 11, 2015

Should be a simple fix: the joins could just return the listenable if there is only one. That way you won't need to do any ifs.

@LongLiveCHIEF
Copy link

-1 to the proposed way of resolving this concern.

@spoike
Copy link
Member

spoike commented Oct 13, 2015

@H3Chief can you elaborate?

@spoike spoike modified the milestones: 0.3.1, 0.2.13 Oct 13, 2015
@devinivy devinivy removed this from the 0.3.1 milestone Mar 9, 2016
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

4 participants