diff --git a/packages/collections-contracts/src/ReadableRecollection.php b/packages/collections-contracts/src/ReadableRecollection.php index 0bfc038..6c0086a 100644 --- a/packages/collections-contracts/src/ReadableRecollection.php +++ b/packages/collections-contracts/src/ReadableRecollection.php @@ -29,10 +29,8 @@ interface ReadableRecollection extends PageableInterface, ReadableCollection // Overridden methods, to widen keys in parameters to accommodate Uuid key // types // - /** * @param mixed $key - * @return bool */ #[\Override] public function containsKey(mixed $key): bool; diff --git a/packages/collections-domain/src/CriteriaPageable.php b/packages/collections-domain/src/CriteriaPageable.php index a7c49b8..f915bee 100644 --- a/packages/collections-domain/src/CriteriaPageable.php +++ b/packages/collections-domain/src/CriteriaPageable.php @@ -96,7 +96,6 @@ final private function __construct( * @template ST * @param ReadableCollection|Selectable $collection * @param int<1,max> $itemsPerPage - * @return static */ final public static function create( ReadableCollection|Selectable $collection, diff --git a/packages/collections-orm/src/QueryPageable.php b/packages/collections-orm/src/QueryPageable.php index 876d306..948a722 100644 --- a/packages/collections-orm/src/QueryPageable.php +++ b/packages/collections-orm/src/QueryPageable.php @@ -81,7 +81,6 @@ final public function getQueryBuilder(): QueryBuilder /** * @param \Closure(QueryBuilder):void $function - * @return static */ final public function updateQueryBuilder(\Closure $function): static { diff --git a/packages/collections-orm/src/QueryRecollection.php b/packages/collections-orm/src/QueryRecollection.php index 0bcf6b1..6355340 100644 --- a/packages/collections-orm/src/QueryRecollection.php +++ b/packages/collections-orm/src/QueryRecollection.php @@ -114,7 +114,6 @@ final public function getQueryBuilder(): QueryBuilder /** * @param \Closure(QueryBuilder):void $function - * @return static */ final public function updateQueryBuilder(\Closure $function): static { diff --git a/rector.php b/rector.php index decf91c..7196e29 100644 --- a/rector.php +++ b/rector.php @@ -35,7 +35,7 @@ // symfonyCodeQuality: true, // doctrineCodeQuality: true, ) - ->withDeadCodeLevel(16) + ->withDeadCodeLevel(17) ->withPhpSets(php82: true) ->withRules([ // AddOverrideAttributeToOverriddenMethodsRector::class, @@ -48,6 +48,7 @@ ], RemoveUselessReturnTagRector::class => [ // static analysis tools don't like this + __DIR__ . '/packages/collections-common/src/Trait/ReadableCollectionTrait.php', __DIR__ . '/packages/collections-common/src/Trait/MinimalReadableRecollectionTrait.php', __DIR__ . '/packages/collections-common/src/Trait/ReadableRecollectionTrait.php', __DIR__ . '/packages/collections-contracts/src/MinimalReadableRecollection.php',